From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9309028DC4 for ; Thu, 29 Jan 2026 17:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769707594; cv=none; b=NShOq4paaQ1/++cNPjHYZbgwd9C5+tW7D3T89BYLF0YA0/8O0VA34nfvKKDVF3jog5Ktwso6oSf0lz3IRAMdwAoen0UukyKjsoV4RPgsZPaHl0C6Wx/VHuyGfDjfUhZ7eDf/eN0wQ3qIdyusiEKhQ2uudBQmjeSZndXaH44knvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769707594; c=relaxed/simple; bh=A59Yh5wWkb+mdrFpiJPtqdgLUKvDHOYYUzfjNPCwgJE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=luYv7rMTqsg9c8BfdUYY/+UfNaopGeFHuFei0J45CtyR5XJI2S4s6kPjnWsb0ixY6Vk8STi9Vhd6BNn+hmxjW774vfdliNSw+Nd/mEFN/qZUjn7dJWKPhcl2qsMd8EYaMO76sYb+oXZld/PWtHNfzv6bK0/fApVLGww7PGCkbns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V+cWTOLm; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V+cWTOLm" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47edffe5540so15484485e9.0 for ; Thu, 29 Jan 2026 09:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769707591; x=1770312391; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5QIfQPTEVW6bvm63WQSInUs8OdHRDtfdNsdIRCSSUF8=; b=V+cWTOLmf8Hx1kj0gHM8ocD5Uc3XTVbL+lpr4JTpEwCrRH7TyU2czXzG84DIBWjUi5 6NXKmXp+3SWjrQLIpCAAhUIMc3kRb3VnoYOONQY2MiYeEzTnxyGNnDpuRShNRG9AlgXm Fj6Xmu2EM4No0tKi6cRLeWZkaIzNZq1obzHCDXGR6uNb+3/ANJtHz4JD1oJxnrtO8tzO AJxxQCY/zJJN88UWF7csnzr30YCxd5KTgMbHNxu1o+VBbwcZUnTH5JME3REEXNnY6ieu ukAHH7BxAWZxTNP3t0CJHOnN4EGgUqn9lCgRTMjYWnb2SM4zRYGrA+RgZ6NBj5rYQYPr 69kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769707591; x=1770312391; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5QIfQPTEVW6bvm63WQSInUs8OdHRDtfdNsdIRCSSUF8=; b=Mo3KkvRumba+bvsy9ThpNEvHu9P1eaNVFBfNwkcuaYPi9Y0ibVeNSx1Xv1YNcrXnQg aOkJgczUb8JimXEFvCuoADMCVLcOXZmt4p9za4Ex8r6usBcyFTy0CDMicmMXLJMBFffw GALUgv5yKsSwXL6EJyFdcDSOUY0VOm1pv9Mfl3n82YLsilalAUpQ1CMfHiIGBUbgwYG8 mok8qfgN/2d6j4u+LXB/Q/wUEdumWOI+VKzxxo8EkX9Jty6aYiFFh+RZSJDSwENkcQ0V Sn1jUUBBzeJ4L9PT+fuD05eW79tcHsgDq/MJwUKZpe4UqgtveUarrDJhOezDdEbuAjTq hkKw== X-Forwarded-Encrypted: i=1; AJvYcCUZ5CVqtXNRKbkNMQYyRajwHBNkpntgfhwVWYboLKckhj+xoR4gp3hb69wmeCjxCIn7sjaNDXuWr9f0j/8=@vger.kernel.org X-Gm-Message-State: AOJu0YznjJGpio+fdNBoJqZ81qCNMTfj7ABQS6UG2ZQG3iI3xdJP9wSU +gaH3YY9tk99MspmP3gsEz2AKU3+yf7XwlpolaF9mwXh3WVJxO+aKrlEzo6Yfg== X-Gm-Gg: AZuq6aI7FqKqxaIndIVIHgQ/67WN9fFoa3P0UadmFcc5A2L/+x2C+Xk0dLvsUuHnxmT y55wprJUopdKz9aK5ATY+4DELFpq30XsmZ8cGse12DYhl/Qe5V5xI02toutrLbr8A/wQp0e5vA6 baZKESlrJUjRcziAm0uDz3bb3eXgxsAlzAfE0ol7B3JpXgYHfYO4wvF3fwEN1OQQ9tO/EpTDnMP evqdTGr4sJPz8D2CbyXXTrdqdQTFmhKNvGV+4C8nCEqFCR5XrnYf36/54ApbYLwxHExmQcBWZS5 Fv+zK0rwOI6DttMGn5lu9yFV9agVoFE+53wnbeRYvokGfC+rMlC8pGZmebz9bB0lENwSVqNaYnW kVZ0P/pqWHDOAXTdKfkJS1tTHp0uIiBtBS0L03ZavmgOwAGsDFayCgiiwp+LZoSXNzaCUzzj64c Mx23JhLwwWhL5IETFkPTc= X-Received: by 2002:a05:600c:4592:b0:480:20f1:7aa6 with SMTP id 5b1f17b1804b1-48069c5b95bmr115125895e9.21.1769707590565; Thu, 29 Jan 2026 09:26:30 -0800 (PST) Received: from [192.168.1.2] ([31.176.185.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm222749765e9.9.2026.01.29.09.26.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 09:26:30 -0800 (PST) Message-ID: <541a60a1-2373-4624-9320-c9b904a7af10@gmail.com> Date: Thu, 29 Jan 2026 18:26:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with proper errno To: Dan Carpenter Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260125221219.26151-1-omer.e.idrissi@gmail.com> <20260128172143.23472-1-omer.e.idrissi@gmail.com> Content-Language: en-US From: Omer El Idrissi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the explanation. I'll drop this change and revisit it once i'm more familiar with the driver On 1/29/26 8:27 AM, Dan Carpenter wrote: > On Wed, Jan 28, 2026 at 06:21:43PM +0100, Omer El Idrissi wrote: >> Changes since v1: >> - Removed leftover comment accidentally left in previous version >> - No functional changes >> >> Signed-off-by: Omer El Idrissi > No commit message. > > https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ > > Why is do you change -2 to both -EBUSY and -ENOBUFS? In the original > code, the -1 and -2 return meant something custom and they weren't > kernel error codes: > > * Return: > *0 Success > *-1 Hardware resource(TX FIFO) not ready > *-2 Software resource(xmitbuf) not ready > > Now the documentation makes no sense. > > regards, > dan carpenter >