From: Logan Gunthorpe <logang@deltatee.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
kernel test robot <fengguang.wu@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>, LKP <lkp@01.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
wfg@linux.intel.com, Alan Cox <alan@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
David Airlie <airlied@linux.ie>,
David Herrmann <dh.herrmann@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [Merge tag 'pci-v4.12-changes' of git] 857f864014: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8
Date: Tue, 13 Jun 2017 23:55:37 -0600 [thread overview]
Message-ID: <541d1104-6139-c902-ec91-943ec1e8a881@deltatee.com> (raw)
In-Reply-To: <20170614050049.GA11630@kroah.com>
On 13/06/17 11:00 PM, Greg Kroah-Hartman wrote:
> No, don't modify any drivers, do this in the core chardev code.
Ok, well then maybe I misunderstood what you originally asked for
because I don't see how you can change a fixed allocation to a dynamic
one without touching the driver code which needs to know the major that
was assigned in the end.
> At quick glance, looks good to me, care to clean it up and make it behind
> a config option?
Sure. However, is a config option really necessary here? As is, the
extended dynamic region will only be used if there are too many chardev
majors and it shouldn't have _any_ effect on users that have a small
number. So it seems like not selecting that option is just telling the
kernel to be broken for no obvious trade-off.
Logan
next prev parent reply other threads:[~2017-06-14 5:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 12:33 kernel test robot
2017-06-06 17:55 ` Bjorn Helgaas
2017-06-06 19:02 ` Logan Gunthorpe
2017-06-12 20:08 ` Bjorn Helgaas
2017-06-12 23:34 ` Logan Gunthorpe
2017-06-13 4:18 ` Greg Kroah-Hartman
2017-06-13 4:29 ` Logan Gunthorpe
2017-06-13 4:34 ` Greg Kroah-Hartman
2017-06-13 4:35 ` Greg Kroah-Hartman
2017-06-13 16:25 ` Logan Gunthorpe
2017-06-13 16:35 ` Greg Kroah-Hartman
2017-06-13 17:47 ` Logan Gunthorpe
2017-06-14 5:00 ` Greg Kroah-Hartman
2017-06-14 5:55 ` Logan Gunthorpe [this message]
2017-06-13 19:13 ` Sven-Haegar Koch
2017-06-14 5:01 ` Greg Kroah-Hartman
2017-06-14 9:59 ` Linus Walleij
2017-06-14 15:49 ` Logan Gunthorpe
2017-06-13 11:48 ` Alan Cox
2017-06-13 16:16 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541d1104-6139-c902-ec91-943ec1e8a881@deltatee.com \
--to=logang@deltatee.com \
--cc=airlied@linux.ie \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dh.herrmann@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@01.org \
--cc=torvalds@linux-foundation.org \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®