mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIV
Date: Tue, 5 Apr 2022 11:07:19 +0200	[thread overview]
Message-ID: <5420967d-5007-8ca7-7a8d-124b9ad96905@gmail.com> (raw)
In-Reply-To: <YksBcUBXbgzXmEBO@kroah.com>

Hi Greg,

On 4/4/22 16:32, Greg KH wrote:
>> +bool support_ant_div(struct adapter *adapter)
> 
> That's a very odd function name to add to the kernel's global namespace
> :(
> 
> Pleas emake it more obvious what this is for, with the driver name as
> part of the prefix?
> 

Looking again at this I notice it can be made a static function in 
rtw_cmd.c.

I'll rework the series and make the function static with a more
descriptive name.

thanks,
Michael

  reply	other threads:[~2022-04-05 13:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 16:52 [PATCH 0/5] staging: r8188eu: remove GetHalDefVar8188EUsb() Michael Straube
2022-04-03 16:52 ` [PATCH 1/5] staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIV Michael Straube
2022-04-04 14:32   ` Greg KH
2022-04-05  9:07     ` Michael Straube [this message]
2022-04-03 16:52 ` [PATCH 2/5] staging: r8188eu: use support_ant_div() Michael Straube
2022-04-03 16:52 ` [PATCH 3/5] staging: r8188eu: remove dead code Michael Straube
2022-04-03 16:52 ` [PATCH 4/5] staging: r8188eu: remove HAL_DEF_CURRENT_ANTENNA Michael Straube
2022-04-03 16:52 ` [PATCH 5/5] staging: r8188eu: remove GetHalDefVar8188EUsb() Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5420967d-5007-8ca7-7a8d-124b9ad96905@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®