From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A907C43331 for ; Thu, 7 Nov 2019 15:56:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 022822085B for ; Thu, 7 Nov 2019 15:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="UOTV3ZRj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730140AbfKGP4i (ORCPT ); Thu, 7 Nov 2019 10:56:38 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:48702 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbfKGP4h (ORCPT ); Thu, 7 Nov 2019 10:56:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1573142194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=szK9N8x12zQUOWIHg7M1eNYFmIkAO79UdwCrGgrs3n4=; b=UOTV3ZRjoIC/iJ/U714q3aeLUVBDSKkwgklX9e7W8X+xxHanBoLKv1NopwY5TW4BNXYUst y4YWpTrVQzQV9BIFkBZtCLTap7zudWifhKh4Z9ffHcsJgDAR0Cwl4VLy5/Ho0qkB4VHYH7 IJSYS+bDnmh1da21zCjSzrQoSKucvWQ= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 07 Nov 2019 16:56:34 +0100 From: Paul Cercueil To: Daniel Lezcano Cc: Thomas Gleixner , od@zcrc.me, linux-kernel@vger.kernel.org, Maarten ter Huurne , Mathieu Malaterre , Artur Rojek Subject: Re: [PATCH] clocksource: Add driver for the Ingenic JZ47xx OST In-Reply-To: References: <20190809123824.26025-1-paul@crapouillou.net> Message-ID: <54210a015f148218e11e7f3c1d107192@crapouillou.net> X-Sender: paul@crapouillou.net Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 2019-08-16 16:54, Daniel Lezcano wrote: > On 09/08/2019 14:38, Paul Cercueil wrote: >> From: Maarten ter Huurne >> >> OST is the OS Timer, a 64-bit timer/counter with buffered reading. >> >> SoCs before the JZ4770 had (if any) a 32-bit OST; the JZ4770 and >> JZ4780 have a 64-bit OST. >> >> This driver will register both a clocksource and a sched_clock to the >> system. >> >> Signed-off-by: Maarten ter Huurne >> Signed-off-by: Paul Cercueil >> Tested-by: Mathieu Malaterre >> Tested-by: Artur Rojek >> --- >> > > [ ... ] > >> + err = clocksource_register_hz(cs, rate); >> + if (err) { >> + dev_err(dev, "clocksource registration failed: %d\n", err); >> + clk_disable_unprepare(ost->clk); >> + return err; >> + } >> + >> + /* Cannot register a sched_clock with interrupts on */ > > Aren't they already disabled? Sorry for the late reply. No, they are not already disabled; this is what I get if I comment out the local_irq_save()/local_irq_restore(): [ 0.361014] clocksource: ingenic-ost: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 159271703898 ns [ 0.361515] clocksource: Switched to clocksource ingenic-ost [ 0.361686] ------------[ cut here ]------------ [ 0.361893] WARNING: CPU: 0 PID: 1 at kernel/time/sched_clock.c:179 sched_clock_register+0x7c/0x2e4 [ 0.362174] CPU: 0 PID: 1 Comm: swapper Not tainted 5.4.0-rc5+ #461 [ 0.362330] Stack : 80744558 80069b44 80770000 00000000 00000000 00dfd7a7 806e6db4 8106bb74 [ 0.362619] 806f0000 81067ca4 806f31c7 80769478 00000020 10000400 8106bb20 00dfd7a7 [ 0.362906] 00000000 00000000 80780000 00000000 00000007 00000001 00000049 3563722d [ 0.363191] 8106ba61 00000000 ffffffff 00000010 806f0000 00000000 00000000 806f0000 [ 0.363477] 00000020 00000000 80714534 80770000 00000002 80319154 00000000 80770000 [ 0.363762] ... [ 0.363906] Call Trace: [ 0.364087] [<8001af14>] show_stack+0x40/0x128 [ 0.364289] [<8002fd88>] __warn+0xb8/0xe0 [ 0.364478] [<8002fe14>] warn_slowpath_fmt+0x64/0xc0 [ 0.364678] [<8072b1c8>] sched_clock_register+0x7c/0x2e4 [ 0.364895] [<8073c874>] ingenic_ost_probe+0x224/0x248 [ 0.365090] [<803d5394>] platform_drv_probe+0x40/0x94 [ 0.365526] [<803d362c>] really_probe+0x104/0x374 [ 0.365743] [<803d3ff0>] device_driver_attach+0x78/0x80 [ 0.365938] [<803d4070>] __driver_attach+0x78/0x118 [ 0.366129] [<803d1700>] bus_for_each_dev+0x7c/0xc8 [ 0.366318] [<803d226c>] bus_add_driver+0x1bc/0x204 [ 0.366513] [<803d4878>] driver_register+0x84/0x14c [ 0.366717] [<8073a144>] __platform_driver_probe+0x98/0x140 [ 0.366931] [<80724e38>] do_one_initcall+0x84/0x1b4 [ 0.367126] [<807250cc>] kernel_init_freeable+0x164/0x240 [ 0.367318] [<805df75c>] kernel_init+0x10/0xf8 [ 0.367510] [<8001542c>] ret_from_kernel_thread+0x14/0x1c [ 0.367722] ---[ end trace 7fedf00408fa3bed ]--- [ 0.367985] sched_clock: 32 bits at 12MHz, resolution 83ns, wraps every 178956970966ns At kernel/time/sched_clock.c:179 there is: WARN_ON(!irqs_disabled()); >> + local_irq_save(flags); >> + if (soc_info->is64bit) >> + sched_clock_register(ingenic_ost_read_cntl, 32, rate); >> + else >> + sched_clock_register(ingenic_ost_read_cnth, 32, rate); >> + local_irq_restore(flags); >> + >> + return 0; >> +} >> +