From: Lars Melin <larsm17@gmail.com>
To: Heiko Schocher <hs@denx.de>, linux-usb@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Oliver Neukum <oliver@neukum.name>,
netdev@vger.kernel.org, linux-api@vger.kernel.org,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Macpaul Lin <macpaul@gmail.com>
Subject: Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis
Date: Wed, 24 Sep 2014 19:25:30 +0700 [thread overview]
Message-ID: <5422B83A.8030406@gmail.com> (raw)
In-Reply-To: <1411541339-32400-1-git-send-email-hs@denx.de>
On 2014-09-24 13:48, Heiko Schocher wrote:
> use the values for RNDIS over Ethernet as defined in
> http://www.usb.org/developers/defined_class
> (search for RDNIS):
>
> - baseclass: 0xef (miscellaneous)
> - subclass: 0x04
> - protocol: 0x01
>
That is usb class, it is not the same thing as communication device class.
> --- a/include/uapi/linux/usb/cdc.h
> +++ b/include/uapi/linux/usb/cdc.h
> @@ -12,6 +12,7 @@
> #include <linux/types.h>
>
> #define USB_CDC_SUBCLASS_ACM 0x02
> +#define USB_CDC_SUBCLASS_RNDIS 0x04
No, no, no.
There is no CDC_SUBCLASS_RNDIS and you can not define one over an
already used cdc subclass number, 0x04 is Multi-Channel Control Model
next prev parent reply other threads:[~2014-09-24 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 6:48 Heiko Schocher
2014-09-24 9:38 ` Michal Nazarewicz
2014-09-24 13:12 ` Heiko Schocher
2014-09-24 12:25 ` Lars Melin [this message]
2014-09-24 13:12 ` Heiko Schocher
2014-09-24 14:22 ` Lars Melin
2014-09-29 12:11 ` Heiko Schocher
2014-09-29 16:05 ` Lars Melin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422B83A.8030406@gmail.com \
--to=larsm17@gmail.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@suse.de \
--cc=hs@denx.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul@gmail.com \
--cc=mina86@mina86.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome