mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Stefan Agner <stefan@agner.ch>,
	shawn.guo@freescale.com, kernel@pengutronix.de,
	daniel.lezcano@linaro.org, tglx@linutronix.de
Cc: bpringlemeir@nbsps.com, linux-kernel@vger.kernel.org,
	jingchang.lu@freescale.com, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] clocksource: vf_pit_timer: Support shutdown mode
Date: Thu, 25 Sep 2014 16:19:56 +0400	[thread overview]
Message-ID: <5424086C.1070901@cogentembedded.com> (raw)
In-Reply-To: <1411575610-20895-2-git-send-email-stefan@agner.ch>

Hello.

On 9/24/2014 8:20 PM, Stefan Agner wrote:

> In order to avoid waking up the system in a low power mode, the
> clocksource should not generate interrupts anymore. Disable the PIT
> timer interrupt when changing into the CLOCK_EVT_MODE_SHUTDOWN mode.

> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>   drivers/clocksource/vf_pit_timer.c | 5 +++++
>   1 file changed, 5 insertions(+)

> diff --git a/drivers/clocksource/vf_pit_timer.c b/drivers/clocksource/vf_pit_timer.c
> index a918bc4..eb354b4 100644
> --- a/drivers/clocksource/vf_pit_timer.c
> +++ b/drivers/clocksource/vf_pit_timer.c
> @@ -89,10 +89,15 @@ static int pit_set_next_event(unsigned long delta,
>   static void pit_set_mode(enum clock_event_mode mode,
>   				struct clock_event_device *evt)
>   {
> +

    scripts/checkpatch.pl should protest about this empty line, it's not 
needed at all.

WBR, Sergei


  reply	other threads:[~2014-09-25 12:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 16:20 [PATCH v2 0/3] ARM: vf610: Fix/add clocksource Stefan Agner
2014-09-24 16:20 ` [PATCH v2 1/3] clocksource: vf_pit_timer: Support shutdown mode Stefan Agner
2014-09-25 12:19   ` Sergei Shtylyov [this message]
2014-09-24 16:20 ` [PATCH v2 2/3] ARM: dts: vf610: Add ARM Global Timer Stefan Agner
2014-09-26  1:41   ` Shawn Guo
2014-09-24 16:20 ` [PATCH v2 3/3] ARM: vf610: Add ARM Global Timer clocksource option Stefan Agner
2014-09-26  1:45   ` Shawn Guo
2014-09-29 11:51   ` Shawn Guo
2014-09-29 12:18     ` Stefan Agner
2014-09-24 17:06 ` [PATCH v2 0/3] ARM: vf610: Fix/add clocksource Bill Pringlemeir
2014-09-26  7:01 ` Daniel Lezcano
2014-09-26  7:24   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5424086C.1070901@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=bpringlemeir@nbsps.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=jingchang.lu@freescale.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@freescale.com \
    --cc=stefan@agner.ch \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome