From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754217AbaIZIoT (ORCPT ); Fri, 26 Sep 2014 04:44:19 -0400 Received: from outbound-smtp02.blacknight.com ([81.17.249.8]:51791 "EHLO outbound-smtp02.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754128AbaIZIoP (ORCPT ); Fri, 26 Sep 2014 04:44:15 -0400 Message-ID: <54252756.6000001@nexus-software.ie> Date: Fri, 26 Sep 2014 09:44:06 +0100 From: "Bryan O'Donoghue" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Dave Hansen , Ong Boon Leong , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" CC: linux-kernel@vger.kernel.org, Andi Kleen , Arjan van de Ven Subject: Re: [PATCH] x86, setup: add __flush_tlb() for Intel Quark X1000 References: <1411705827-2522-1-git-send-email-boon.leong.ong@intel.com> <1411705827-2522-2-git-send-email-boon.leong.ong@intel.com> <5424FA7C.6020303@intel.com> In-Reply-To: <5424FA7C.6020303@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/14 06:32, Dave Hansen wrote: > I'd just say: > > Quark X1000 wrongly advertises PGE. Work around this with an > unconditional full flush using a CR3 write instead of CR4.PGE: Hi Dave. In another thread with Ingo Molnar and Henrique de Moraes Holschuh the following text was proposed. + /* + * Locate the page directory and flush the TLB. + * + * On Quark X1000 CPUs we still have the PGE bit incorrectly set + * due to a processor erratum, so __flush_tlb_all() is not yet + * doing what it says. Fortunately we have a cr3 flush here, + * which is what is needed in this processor to flush TLBs, so + * there's no need to add a Quark X1000 quirk here. + * + * early_init_intel will unset the X86_FEATURE_PGE flag later + * and __flush_tlb_all() will flush via cr3 + */ Path submitted as "[PATCH] x86: Quark: Comment setup_arch for TLB/PGE bugfix" Does that work for you ? -- BOD