Re: [Intel-wired-lan] [PATCH iwl-next v3] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

["Lifshits, Vitaly" <vitaly.lifshits@intel.com>]

On 2/18/2025 2:59 PM, Simon Horman wrote:
> On Sun, Feb 16, 2025 at 04:57:28PM +0100, Piotr Wejman wrote:
>> Update the driver to use the new hardware timestamping API added in commit
>> 66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
>> Use Netlink extack for error reporting in e1000e_config_hwtstamp.
>> Align the indentation of net_device_ops.
>>
>> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>> Signed-off-by: Piotr Wejman <wejmanpm@gmail.com>
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Reviewed-by: Vitaly Lifshits <vitaly.lifshits@intel.com>

> 
> ...
> 
>> @@ -3932,7 +3939,11 @@ static void e1000e_systim_reset(struct e1000_adapter *adapter)
>>   	spin_unlock_irqrestore(&adapter->systim_lock, flags);
>>   
>>   	/* restore the previous hwtstamp configuration settings */
>> -	e1000e_config_hwtstamp(adapter, &adapter->hwtstamp_config);
>> +	ret_val = e1000e_config_hwtstamp(adapter, &adapter->hwtstamp_config, &extack);
> 
> nit: If there is a v4 for some other reason, please consider line-wrapping
>       the above to avoid lines that are more than 80 columns wide.
> 
> 	ret_val = e1000e_config_hwtstamp(adapter, &adapter->hwtstamp_config,
> 					 &extack);
> 
>> +	if (ret_val) {
>> +		if (extack._msg)
>> +			e_err("%s\n", extack._msg);
>> +	}
>>   }
>>   
>>   /**
>> @@ -6079,8 +6090,8 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu)
>>   	return 0;
>>   }
>>   
>> -static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr,
>> -			   int cmd)
>> +static int e1000_ioctl(struct net_device *netdev, struct ifreq *ifr,
>> +		       int cmd)
> 
> nit: And conversely, if there is a v4 for some other reason,
>       please consider merging the above two lines into one.
> 
> ...