From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5588134DCD6 for ; Tue, 7 Apr 2026 11:05:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559924; cv=none; b=OpL9AIDOHUmj+TEFwZAngQNQkWOUq62OV/l7tA4QIqia2VWWTY7xBmpbSc3XyNP2ysPOtvqCTikM/Q6SXu47ESxTQpw1FD86ruBNuDfz/cF21FY2zK8cMH6aBhVy6wrx4KQctKn0wULpATWduskn2r3YeGSCkXnHNXXESH5E1T0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559924; c=relaxed/simple; bh=AASHIeM6Gd/EK8pPUVGREs94mOWAxENDbLt05y2wNeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EsTMLUypDYWg5Cb8pJcp3aTRdIkLy2Wm2ofNQpFyQmjLPYTAXdgqxfpaYK8G6xkdmlrEjT5HlCnz2Mq4o/IAA08SXZ6+vDN/YZPzv8O7yfopvB0/DvDlGHJdK5h2/mk2+F8qOdCm/KfFYCRpJAMXDHwPdFp8Bp6f/yFzHxDNn8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eIwCV8wQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rZcB61Kc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eIwCV8wQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rZcB61Kc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775559922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbK7CgYMpXwezHmMj9q3jIIWcerGUMg8y8tq/mmBKaU=; b=eIwCV8wQbO7XXAOzetcW3/z0oCvl8Mo3G6fvtgvHWd4elWtleO6aSzodAHlL4BUX+FeqxM 3pmTad4O5mUAyjiBkr6b3tTfEsH5Um23y/purXaftoQdbv1TQs/bo62iZQ6Ad70dlwt/q4 gQ4/0Qp1+3mgnjcJnmbL1LA3O2eb4iY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-258--i80apLBOsWYgzUlkGjXXQ-1; Tue, 07 Apr 2026 07:05:21 -0400 X-MC-Unique: -i80apLBOsWYgzUlkGjXXQ-1 X-Mimecast-MFC-AGG-ID: -i80apLBOsWYgzUlkGjXXQ_1775559919 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-488be6ab870so2929095e9.3 for ; Tue, 07 Apr 2026 04:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775559919; x=1776164719; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nbK7CgYMpXwezHmMj9q3jIIWcerGUMg8y8tq/mmBKaU=; b=rZcB61Kc8NPGgYbMzb/JYMGXuNdvI5f5gUsLxbyal5GzR7v165QukGPFpNhy0ofZ1E XDx+krKgaeJKQXA/e4Xf5jHfnabAs4abVfIi3+jtvO7sqmMKUSmIIeCDIK3QPLDVvYyT pIaf7RK2m+m83coHckxLAGV22SSJ2XVKw8+gWS29ikT5+XRR9gNZPZ3nmSZj4qLu2v99 xoHGXI3podZuvwWKPOIzVurcOMnxeyTZfccZAV3Q0nNxYde7lo967WpRetGZQoDbC3jA zO7N52JlG2tuol+Fnk1Kw6V+Bq5jeUUdYEoeRMgaJQUZCUmlcPA/fO+S+gjCniyd6TwY XHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775559919; x=1776164719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nbK7CgYMpXwezHmMj9q3jIIWcerGUMg8y8tq/mmBKaU=; b=NrjQ52WsHytBYgvXBCRcpqWPR5a4X+suiVC2bqZ3cCLgQg5+WKharPgsdBrqP3z+9m oZXpA2UnBfMZdo0vFQ4T0yU3ikqAqXl+JezZMLVIRkP02d/+7b9N9Hs3rxTqo07RpnAI 8Iv8xajZyN+el/urVhOoQpNsdiNXCfadAxaDR9jHPdqXS9x0MQEfhnOZWEcvdXUFD1oe J01IafcJvdojYWbp8x9gO8NH5KQOvdJnOV97NnE8DIhlfFHNPrEYvHXOWTJWwjawYyw8 l10dQ6hNUKBzOLWrVDSYPQCdOOIhLONYeEyCgvJmEQ8+W/bJ7IP+BfhYHGaP152cSiTx PyNQ== X-Forwarded-Encrypted: i=1; AJvYcCVNtUpZw+13GBCqdicKhhFYSe2DwvGU8Eclmjislog0TtVhgjtsZAh3/nWPmMoASZBAnTbHA1Mex6d2D1g=@vger.kernel.org X-Gm-Message-State: AOJu0YzpUefXm9GmGZZJ7b2TwwDIYMCXLpMXWJxyzrM7mcoZvbDHZiya xAGOV/GD0om/A6Jil/3fcen02dMl6CE6U/OF42+h9NSEs0l22CJnRdKx6i/6bx2du60ifDKr709 JWqQV3szXffXusJiLz5VQNHX230RtXkjawmAmPrFDbAX1g5Srwvk0ea0BVqaMmtHPQw== X-Gm-Gg: AeBDiesWbbmKaufp/KCuONCplrfJopltAgpWmsf1rUoq+3sRyPI7xtCW8buS4cM+aq+ RDTfiZwBFGzN9rJdbhmmi6dDO3l7E5HzW2GjgLNuUdRcNbNV+61wXze83k0Q8/m960v07ORa8XQ g+m93ChtVeKnkohVwOm81BCUfYGcsNqzWFFgjKwPzin4s8gnRZnE7edeNatyyPsW2T1nvTz9Ndi Grd+1L05tZiVuX/9lmDkF9oP9yPaCNg04g0lafoT+2foUX55p9jH8yH8sf3YfO5h29TE1G7RQC5 duW9JNLJ6dC5I8jT1mqxjq+ILonJzzb/TzwPpalFhZy71avhc7wu4LQqBj5Q0oHBeNTGpWlS2ui 44uaetellgs7BAE1C59cC6BEdrzC+e+QdmviLAWkNBEQTfZWKb/9PvQLxtg== X-Received: by 2002:a05:600c:8207:b0:488:c282:e77e with SMTP id 5b1f17b1804b1-488c282e7ecmr4113815e9.28.1775559919405; Tue, 07 Apr 2026 04:05:19 -0700 (PDT) X-Received: by 2002:a05:600c:8207:b0:488:c282:e77e with SMTP id 5b1f17b1804b1-488c282e7ecmr4113325e9.28.1775559918924; Tue, 07 Apr 2026 04:05:18 -0700 (PDT) Received: from [192.168.88.32] ([212.105.153.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48899d1b19esm165793205e9.6.2026.04.07.04.05.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:05:18 -0700 (PDT) Message-ID: <5428a986-98f0-425d-858d-5ef766992d0e@redhat.com> Date: Tue, 7 Apr 2026 13:05:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] pppoe: drop PFC frames To: qingfang.deng@linux.dev, Simon Horman Cc: linux-ppp@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Jaco Kroon , James Carlson , Wojciech Drewek , Guillaume Nault References: <20260403083926.68320-1-qingfang.deng@linux.dev> <20260406144828.GH395680@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/7/26 5:19 AM, qingfang.deng@linux.dev wrote: > April 6, 2026 at 10:48 PM, Simon Horman wrote: >> I think it would be best to add/use a #define rather than >> open coding the magic value 0x01. And perhaps expanding >> the comment to note that skb->data[0] is the first byte >> of the PPP protocol would be nice too. > > The field does not have a canonical name. As per RFC1661, the LSB of the > first octet is used to test if the protocol field is compressed, and the > same code snippet is used in ppp_generic.c. > > I could instead add a helper function: > > static inline bool ppp_skb_is_compressed_proto(const struct sk_buff *skb) > { > return skb->data[0] & 0x01; > } > > What do you think? The helper LGTM, and could be re-used in ppp_generic.c, too. /P