From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153AbaI2Oq6 (ORCPT ); Mon, 29 Sep 2014 10:46:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35259 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbaI2Oq4 (ORCPT ); Mon, 29 Sep 2014 10:46:56 -0400 Message-ID: <542970D5.7010507@suse.de> Date: Mon, 29 Sep 2014 16:46:45 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: zhang.lyra@gmail.com CC: catalin.marinas@arm.com, gregkh@linuxfoundation.org, ijc+devicetree@hellion.org.uk, jslaby@suse.cz, galak@codeaurora.org, broonie@linaro.org, mark.rutland@arm.com, m-karicheri2@ti.com, pawel.moll@arm.com, artagnon@gmail.com, rrichter@cavium.com, robh+dt@kernel.org, will.deacon@arm.com, orsonzhai@gmail.com, geng.ren@spreadtrum.com, zhizhou.zhang@spreadtrum.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/6] arm64: dts/Makefile: Add support for Spreadtrum's Shark64 SoC. References: <1411991314-6636-1-git-send-email-zhang.lyra@gmail.com> <1411991314-6636-4-git-send-email-zhang.lyra@gmail.com> In-Reply-To: <1411991314-6636-4-git-send-email-zhang.lyra@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 29.09.2014 um 13:48 schrieb zhang.lyra@gmail.com: > From: "zhizhou.zhang" > > Adds build support for Spreadtrum's Shark64 SoC in arm64 dts Makefile. > > Signed-off-by: zhizhou.zhang > Signed-off-by: chunyan.zhang > --- > arch/arm64/boot/dts/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index c52bdb0..7fdb9df 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -1,5 +1,6 @@ > dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb > dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb > +dtb-$(CONFIG_ARCH_SHARK64) += sprd_shark64.dtb > > targets += dtbs > targets += $(dtb-y) This patch seems so trivial that you could just squash it into 2/6 (adding the .dts file). Also, it looks to me as if the ordering is alphabetical, so SHARK should probably go somewhere before VEXPRESS, not after XGENE. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg