From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbaJDLFT (ORCPT ); Sat, 4 Oct 2014 07:05:19 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:38676 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbaJDLFS (ORCPT ); Sat, 4 Oct 2014 07:05:18 -0400 Message-ID: <542FD466.6080603@gmail.com> Date: Sat, 04 Oct 2014 16:35:10 +0530 From: Varka Bhadram User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Chen Gang , wg@grandegger.com, mkl@pengutronix.de, fengguang.wu@intel.com, b29396@freescale.com CC: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM References: <542FC556.6060306@gmail.com> In-Reply-To: <542FC556.6060306@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen Gang I think commit message should be short and proper. We can remove *drivers/net/can/m_can/Kconfig* in the commit, just give *can: Kconfig: * commit message like : *can: Kconfig: Fix CAN_M_CAN dependency* On Saturday 04 October 2014 03:30 PM, Chen Gang wrote: > CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with > allmodconfig under um): > > MODPOST 1205 modules > ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined! > ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined! > > Signed-off-by: Chen Gang > --- > drivers/net/can/m_can/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig > index fca5482..14c9fcf 100644 > --- a/drivers/net/can/m_can/Kconfig > +++ b/drivers/net/can/m_can/Kconfig > @@ -1,4 +1,5 @@ > config CAN_M_CAN > tristate "Bosch M_CAN devices" > + depends on HAS_IOMEM > ---help--- > Say Y here if you want to support for Bosch M_CAN controller. -- Thanks and Regards, Varka Bhadram.