From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755988AbcHVO3s (ORCPT ); Mon, 22 Aug 2016 10:29:48 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37232 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755424AbcHVO3i (ORCPT ); Mon, 22 Aug 2016 10:29:38 -0400 Subject: Re: [PATCH 1/2] ARM64: dts: amlogic: gxbb: pinctrl: add pins for PWM To: Linus Walleij References: <1471870450-11109-1-git-send-email-narmstrong@baylibre.com> <1471870450-11109-2-git-send-email-narmstrong@baylibre.com> Cc: Kevin Hilman , Carlo Caione , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" From: Neil Armstrong Organization: Baylibre Message-ID: <542e167e-f66e-551c-8140-bcc19a929ae8@baylibre.com> Date: Mon, 22 Aug 2016 16:28:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22/2016 04:10 PM, Linus Walleij wrote: > On Mon, Aug 22, 2016 at 4:04 PM, Neil Armstrong wrote: >> On 08/22/2016 04:02 PM, Linus Walleij wrote: >>> On Mon, Aug 22, 2016 at 2:54 PM, Neil Armstrong wrote: >>> >>>> Add support for PWM pins, for EE and AO domains. >>>> >>>> Signed-off-by: Neil Armstrong >>> >>> The $SUBJECT of this patch is titallyt wrong, it should be >>> just pinctrl: (something). >>> >>> Should I fix it up or would you like to resend? >>> >>> It looks nice otherwise. >>> >>> Yours, >>> Linus Walleij >>> >> >> Hi Linus, >> >> Yes, sorry I missed the subject. >> >> If you can fixup, it would be great ! > > Hm I tried but the patch does not apply on my "devel" branch > in pinctrl. I chicken out and ask you to rebase it, there are a few > other patches to this driver in the devel branch. > > Yours, > Linus Walleij > Hi, This patch applies perfectly on the current kernel/git/linusw/linux-gpio.git devel branch at 7d9e59ce761f2ebe0bf57e6467cc13d932ee109b "gpio: wcove-gpio: add get_direction method". When I rebase, the patch stays identical. Neil