From: Gabriele Monaco <gmonaco@redhat.com>
To: Wen Yang <wen.yang@linux.dev>
Cc: Nam Cao <namcao@linutronix.de>,
linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] rv/reactors: export rv_register_reactor() and rv_unregister_reactor()
Date: Tue, 15 Sep 2026 09:45:55 +0200 [thread overview]
Message-ID: <542f1065c1daf5167f77e160de90e9a04eb20159.camel@redhat.com> (raw)
In-Reply-To: <2c408ff5-9a13-438e-9068-21b3f1516fbd@linux.dev>
On Mon, 2026-09-14 at 00:33 +0800, Wen Yang wrote:
> Thanks for the review, Gabriele, I agree with your points and will
> follow them.
>
> Just to clarify the background : the struct module * field and the
> try_module_get()/module_put() logic were added to address the point
> raised by sashiko. After this change sashiko no longer complains about it.
Yeah I imagined it, sashiko has a point, whatever is EXPORTed can be used by
modules, so it may imply modules are supported.
What sashiko ignores is maintainability requirements.
A human is reviewing anyone trying to use reactors as modules, and adding that
change without properly advertising it may do more harm than good.
> The module-based reactor support, together with its kselftest, will be
> send as a separate series in a few days.
Sounds good, so I can review and test it as it deserves.
> As a side note, we are looking into using the rv framework for
> functional safety in autonomous driving. Depending on how internal
> validation progress, there will likely be further changes to the rv
> subsystem in the near future. I'll be glad to discuss them as they come.
Nice, thanks for sharing, I had a few conversations about RV in functional
safety domains over the past weeks, I now better understand the challenges.
It'd be very interesting to discuss your requirements too.
Thanks,
Gabriele
next prev parent reply other threads:[~2026-09-15 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 17:10 [PATCH v5 0/5] rv/reactors: fix lockdep warning and add tests wen.yang
2026-09-06 17:10 ` [PATCH v5 1/5] rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type wen.yang
2026-09-06 17:10 ` [PATCH v5 2/5] rv/reactors: propagate rv_register_reactor() error from reactor init wen.yang
2026-09-06 17:10 ` [PATCH v5 3/5] rv/reactors: export rv_register_reactor() and rv_unregister_reactor() wen.yang
2026-09-11 6:53 ` Gabriele Monaco
2026-09-13 16:33 ` Wen Yang
2026-09-15 7:45 ` Gabriele Monaco [this message]
2026-09-06 17:10 ` [PATCH v5 4/5] rv/reactors: add KUnit tests for reactor registration and dispatch wen.yang
2026-09-06 17:10 ` [PATCH v5 5/5] selftests/verification: Test loadable module-based reactor wen.yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542f1065c1daf5167f77e160de90e9a04eb20159.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®