From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C7E1C43387 for ; Wed, 9 Jan 2019 10:56:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34ECE20883 for ; Wed, 9 Jan 2019 10:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730476AbfAIK4z (ORCPT ); Wed, 9 Jan 2019 05:56:55 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:62739 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729752AbfAIK4y (ORCPT ); Wed, 9 Jan 2019 05:56:54 -0500 Received: from 79.184.254.168.ipv4.supernova.orange.pl (79.184.254.168) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.183) id 193b28f482ec75c2; Wed, 9 Jan 2019 11:56:52 +0100 From: "Rafael J. Wysocki" To: Viresh Kumar , Quentin Perret Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, qais.yousef@arm.com Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path Date: Wed, 09 Jan 2019 11:56:06 +0100 Message-ID: <5435767.4D6MIGYIVi@aspire.rjw.lan> In-Reply-To: <20190109104511.mi3gtdcytkky4eyn@vireshk-i7> References: <20190109104236.6532-1-quentin.perret@arm.com> <20190109104511.mi3gtdcytkky4eyn@vireshk-i7> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, January 9, 2019 11:45:11 AM CET Viresh Kumar wrote: > On 09-01-19, 10:42, Quentin Perret wrote: > > The scmi-cpufreq driver calls the arch_set_freq_scale() callback on > > frequency changes to provide scale-invariant load-tracking signals to > > the scheduler. However, in the slow path, it does so while specifying > > the current and max frequencies in different units, hence resulting in a > > broken freq_scale factor. > > > > Fix this by passing all frequencies in KHz, as stored in the CPUFreq > > frequency table. > > > > Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI > > message protocol") > > Signed-off-by: Quentin Perret > > --- > > drivers/cpufreq/scmi-cpufreq.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > > index 50b1551ba894..3f0693439486 100644 > > --- a/drivers/cpufreq/scmi-cpufreq.c > > +++ b/drivers/cpufreq/scmi-cpufreq.c > > @@ -52,9 +52,9 @@ scmi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index) > > int ret; > > struct scmi_data *priv = policy->driver_data; > > struct scmi_perf_ops *perf_ops = handle->perf_ops; > > - u64 freq = policy->freq_table[index].frequency * 1000; > > + u64 freq = policy->freq_table[index].frequency; > > > > - ret = perf_ops->freq_set(handle, priv->domain_id, freq, false); > > + ret = perf_ops->freq_set(handle, priv->domain_id, freq * 1000, false); > > if (!ret) > > arch_set_freq_scale(policy->related_cpus, freq, > > policy->cpuinfo.max_freq); > > Acked-by: Viresh Kumar This would be stable-candidate I guess?