From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML
Date: Thu, 6 Apr 2023 20:39:11 +0200 [thread overview]
Message-ID: <5437085b-706b-2f9a-686e-b95a9a0e6993@linaro.org> (raw)
In-Reply-To: <6720f61e-550f-6e16-8860-54233a3ea069@linaro.org>
On 6.04.2023 20:30, Krzysztof Kozlowski wrote:
> On 06/04/2023 20:26, Konrad Dybcio wrote:
>
>>>> + interrupts:
>>>> + items:
>>>> + - description: CE0
>>>> + - description: CE1
>>>> + - description: CE2
>>>> + - description: CE3
>>>> + - description: CE4
>>>> + - description: CE5
>>>> + - description: CE6
>>>> + - description: CE7
>>>> + - description: CE8
>>>> + - description: CE9
>>>> + - description: CE10
>>>> + - description: CE11
>>>
>>> What about interrupt-names here? If they are not expected, then just
>>> interrupt-names: false
>> They obviously wouldn't hurt, but they're unused on the driver side:
>>
>> for (i = 0; i < CE_COUNT; i++) {
>> ret = platform_get_irq(ar_snoc->dev, i);
>>
>> So I will forbid them.
>
> Assuming DTS does not have them.
Tested locally, no warnings, so looks like nobody used them in dt.
Konrad
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-04-06 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 12:55 [PATCH v3 0/2] ATH10K YAML conversion Konrad Dybcio
2023-04-06 12:55 ` [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML Konrad Dybcio
2023-04-06 17:09 ` Rob Herring
2023-04-06 17:15 ` Krzysztof Kozlowski
2023-04-06 18:26 ` Konrad Dybcio
2023-04-06 18:30 ` Krzysztof Kozlowski
2023-04-06 18:39 ` Konrad Dybcio [this message]
2023-04-11 15:59 ` Krzysztof Kozlowski
2023-04-11 18:00 ` Konrad Dybcio
2023-04-06 12:55 ` [PATCH v3 2/2] arm64: dts: qcom: sdm845-polaris: Drop inexistent properties Konrad Dybcio
2023-04-07 18:36 ` (subset) [PATCH v3 0/2] ATH10K YAML conversion Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437085b-706b-2f9a-686e-b95a9a0e6993@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®