mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wanpeng Li <kernellwp@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
	Kirill V Tkhai <tkhai@yandex.ru>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: do not try to push tasks if pinned task switches to dl
Date: Fri, 10 Oct 2014 18:26:42 +0800	[thread overview]
Message-ID: <5437B462.4050102@gmail.com> (raw)
In-Reply-To: <20141010101016.GJ10832@worktop.programming.kicks-ass.net>


于 10/10/14, 6:10 PM, Peter Zijlstra 写道:
> On Fri, Oct 10, 2014 at 10:43:17AM +0800, Wanpeng Li wrote:
>> As Kirill mentioned(https://lkml.org/lkml/2013/1/29/118):
>> | If rq has already had 2 or more pushable tasks and we try to add a
>> | pinned task then call of push_rt_task will just waste a time.
>>
>> Just switched pinned task is not able to be pushed. If the rq had had
>> several dl tasks before they have already been considered as candidates
>> to be pushed (or pulled). This patch does the same behavior as rt class
>> which introduced by commit 104479 (sched/rt: Do not try to push tasks
>> if pinned task switches to RT).
> Checkpatch rightly complains:
>
> ERROR: Please use 12 or more chars for the git commit ID like: 'commit 10447917551e ("sched/rt: Do not try to push tasks if pinned task switches to RT")'
> #12:
> which introduced by commit 104479 (sched/rt: Do not try to push tasks

I also got this warning before send out the patch, however, I check 6 
chars is enough for this commit. Anyway, I will send a newer version later.

Regards,
Wanpeng Li

>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2014-10-10 10:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  2:43 Wanpeng Li
2014-10-10 10:10 ` Peter Zijlstra
2014-10-10 10:26   ` Wanpeng Li [this message]
2014-10-10 10:56     ` Peter Zijlstra
2014-10-10 11:00       ` Wanpeng Li
2014-10-20 15:42     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5437B462.4050102@gmail.com \
    --to=kernellwp@gmail.com \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tkhai@yandex.ru \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome