From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbaJKLmP (ORCPT ); Sat, 11 Oct 2014 07:42:15 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbaJKLmO (ORCPT ); Sat, 11 Oct 2014 07:42:14 -0400 Message-ID: <54391792.40508@nod.at> Date: Sat, 11 Oct 2014 13:42:10 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Nicolas Iooss , Jeff Dike , user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] um: always use the same type for __syscall_stub_start References: <1413026981-9667-1-git-send-email-nicolas.iooss_linux@m4x.org> In-Reply-To: <1413026981-9667-1-git-send-email-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.10.2014 um 13:29 schrieb Nicolas Iooss: > syscall_stub_start is declared with different types in C files: > > arch/um/kernel/physmem.c: extern int __syscall_stub_start; > arch/um/kernel/skas/mmu.c: extern int __syscall_stub_start; > arch/um/os-Linux/skas/mem.c: extern unsigned long __syscall_stub_start; > arch/um/os-Linux/skas/process.c: extern int __syscall_stub_start; > > Fix this inconsistency by always using unsigned long. This does not > change anything in the compiled code because only the address of > __syscall_stub_start is used, but it makes the static checker I use > stop complaining about incompatible declarations. While we're here, can you put these declarations into a single header file? Thanks, //richard