From: Jens Axboe <axboe@fb.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>, <linux-kernel@vger.kernel.org>
Cc: <keith.busch@intel.com>
Subject: Re: [PATCH] block: update locking context for blk_free_devt
Date: Mon, 13 Oct 2014 14:18:57 -0600 [thread overview]
Message-ID: <543C33B1.2010700@fb.com> (raw)
In-Reply-To: <1413225357-18981-1-git-send-email-dmonakhov@openvz.org>
On 2014-10-13 12:35, Dmitry Monakhov wrote:
> After 2da78092 this function will not longer sleepy
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> block/genhd.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 09da5e4..ae9aaa5 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -441,12 +441,10 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
> * Free @devt which was allocated using blk_alloc_devt().
> *
> * CONTEXT:
> - * Might sleep.
> + * Don't care.
> */
> void blk_free_devt(dev_t devt)
> {
> - might_sleep();
> -
> if (devt == MKDEV(0, 0))
> return;
What's this against? The might_sleep() was killed about a month ago by
commit 46f341ffcfb5. The comment wasn't updated though, it should be.
--
Jens Axboe
next prev parent reply other threads:[~2014-10-13 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 18:35 Dmitry Monakhov
2014-10-13 20:18 ` Jens Axboe [this message]
2014-10-13 20:26 ` Dmitry Monakhov
2014-10-13 20:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543C33B1.2010700@fb.com \
--to=axboe@fb.com \
--cc=dmonakhov@openvz.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome