From: Martin Kelly <martin@martingkelly.com>
To: David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
tglx@linutronix.de, mingo@redhat.com,
Martin Kelly <martkell@amazon.com>
Subject: Re: [PATCH] xen/setup: add paranoid index check and warning
Date: Tue, 14 Oct 2014 07:04:22 -0700 [thread overview]
Message-ID: <543D2D66.7040000@martingkelly.com> (raw)
In-Reply-To: <543CEB56.3080009@citrix.com>
On 10/14/2014 02:22 AM, David Vrabel wrote:
> On 14/10/14 02:19, Martin Kelly wrote:
>> In a call to set_phys_range_identity, i-1 is used without checking that
>> i is non-zero. Although unlikely, a bug in the code before it could
>> cause the value to be 0, leading to erroneous behavior. This patch adds
>> a check against 0 value and a corresponding warning.
>
> This can only happen if the toolstack supplies a memory map with zero
> entries. I could see justification for adding a panic at the top of
> this function in this case, but I can't see the usefulness of this warning.
>
Yes, a panic is probably appropriate. What do you think about the relative merits of panicing in the callers vs. in the sanitize_e820_map function itself (thus to avoid a bunch of similar error checks in the callers)?
next prev parent reply other threads:[~2014-10-14 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 1:19 Martin Kelly
2014-10-14 9:22 ` David Vrabel
2014-10-14 14:04 ` Martin Kelly [this message]
2014-10-14 16:09 ` David Vrabel
2014-10-14 16:28 ` Martin Kelly
2014-10-17 3:49 ` Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543D2D66.7040000@martingkelly.com \
--to=martin@martingkelly.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martkell@amazon.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome