Re: [Patch v2] x86: Make Atom PMC driver configurable.

["Li, Aubrey" <aubrey.li@linux.intel.com>]

On 2014/10/16 13:24, Ingo Molnar wrote:
> 
> * Dave Jones <davej@redhat.com> wrote:
> 
>> The Atom PMC driver is always built-in, regardless of whether
>> the kernel being built is going to be run on an Atom (or even Intel) CPU.
>>
>> Signed-off-by: Dave Jones <davej@redhat.com>
>> Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
>> Cc: aubrey.li@linux.intel.com
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index f2327e88e07c..b4dfd96aeea8 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -2485,7 +2485,8 @@ config X86_DMA_REMAP
>>  	depends on STA2X11
>>  
>>  config PMC_ATOM
>> -	def_bool y
>> +	tristate "Intel Atom SOC power management controller driver"
>> +	default y
>>          depends on PCI
>>  
> 
> So what I think should happen is to decouple of the 'must work' 
> features from the optional debug features in this 'driver': the 
> Atom SoC power-off quirk should be made unconditional, as long as 
> the .config is Atom-supported (CPU_SUP_INTEL I guess).
> 
> All the other bits, such as the debugfs interface, should be in a 
> separately and appropriately named config option, 
> CONFIG_X86_INTEL_ATOM_PMC_DEBUG=y or so, with 'default n'.
> 
> The file should probably be split up, the quirk moved into one of 
> the generic quirk files, while pmc_atom.c should have the debugfs 
> interface.
> 
> That way we don't break anyone and remove the unnecessary code as 
> well. It's also a nice clean up.

Thanks for the suggestion, I'll take a look if I can refine it after
I clean up my plate. Please expect a delay here.

-Aubrey

> 
> Thanks,
> 
> 	Ingo
> 
>