From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5388713D297 for ; Tue, 21 Jan 2025 07:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737445573; cv=none; b=qUfJPjeWi//7VTLN8qahWQ9DNUQ86CyKPG4vpRHMaDpaWqdMZrHEgngtPTj7zkXJCGTPdTwsVNee7FlXbxLVfKXWzbPGR89SsqUM6DMImYOwhB+hM/BrBYoqiQZzXXZAYDqxs8A1oTfZxRAqQGCLTynn27PRuE4bzdRZNTRyTH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737445573; c=relaxed/simple; bh=t5p3MwSM0RSAao+fxMV0KIon6THCl9Fu1qn5bX2IMTI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KGmKxV4nkXKdOwoPLmLdNbMjM+T8NVOS1ih2JtSMXBQTnWhqlR4nyHhm8EgjBbHXEHp/y08iichi/c2QP10oZ7vP5+ogFvVDmzkc9VZ7FCrG1xjQqXPy7K9MOx+jkVX4oHqamUhxiGbQQG/s99SARyJZWHB9diF8ZWhFcUlI8y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LHD8IrZH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LHD8IrZH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737445570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Yf3Yi58DQb9qNm+rQFMRrAIPu7GSswztWbh56zFGwbw=; b=LHD8IrZHSzZIqPu1URLn0h75bi+1eq8//QWielS7R2wrW0lyakZmzN25UV6bgqdCk/ND1m P/mWeukrVpPJRpCs4J36JdKkBsHjU1coWVs4inJPBUk1tzjxcFA7bk49yLch8bxBkOfwgO aSkOXH1vU9i6WIoewf8Hr/iipMo2k18= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-vOLeD40uM5u2pXkjcm3R2A-1; Tue, 21 Jan 2025 02:46:08 -0500 X-MC-Unique: vOLeD40uM5u2pXkjcm3R2A-1 X-Mimecast-MFC-AGG-ID: vOLeD40uM5u2pXkjcm3R2A Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43621907030so41245085e9.1 for ; Mon, 20 Jan 2025 23:46:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737445567; x=1738050367; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Yf3Yi58DQb9qNm+rQFMRrAIPu7GSswztWbh56zFGwbw=; b=UVJ/EentIHrJN3Nt+GB20ZMtf85/I9hBP3gojZAJ4UbtjVsZV4QSyQTEuW18brBPgw fps1RgRJFx7mFxIzIYHMczlLC3D4BslFu/gXpTI91xLSgOv40NCcvljdtCFUTjpwHbyV IL+9BbBL013ImjP6tHsIPmbOng2LLnEM2JHjFPCArK68nuGF4U/i+6+mtUpeQPnA32M8 /ZP8Lo20C43Nbyui4t4aZVSnysJHz4o3PkrZ467TEqSIivcBZTCYfqgVf6TR69zPIISB ToFGU2QlTbqKu82IEH++XeuAq/ml3BSIMCXGH7AtYRPB6S2YlrrY5q0Q9dmIcL58kqJH wzkA== X-Gm-Message-State: AOJu0Yxd4BURl69uw1p5BuNcyH4Yefew6phUOj3rOF2qzBcR9PaC+xuZ SYcDUcTKEIl2DO94y6VMI0v9eoEFrmwhOOCOCu0CyBAVGKcBBq9NpWYQAiW2HrXqxpttrXQVOeD Yfvof28ZpLj4xjoTICSpq1K/KNQpuXvIapmukYyA7OIQAw9qSqJFyfBX0JCrYBw== X-Gm-Gg: ASbGncuch3IBNYGPvKOGSIUkRaloEJgWQLreFsQ0llaaQ3dnq6LHz5s/OYbgoTdBQVW chveyVCFbE23YqjgpCkrMfzcS9nTjqey1YIEfWDuDJNbAKntk7uAyM1qENX7pjB71yn162S5jb/ qlCkFcO57sHLr8BAfyWL9VtlSoc63qgT7W4Q4AZbeXsP47iTVjkVlB21HT4WYNk+GjgS947PC59 02bhtv3x9eXwqdnQ6FBuVQmYY8oUo9EL1T2Gha8id4tlYQ/6M/4FvY29fFt67ZnUbluvTNNTG69 y5NlbXnFUEOmtbGATO1dhYHrvqvRN26JWPesKRLr63Eq+UoazzyIBgbmP3YSnN/Jsg9MpkN9w+1 G5fjIVE1wYigb+/5T7PM28w== X-Received: by 2002:a05:600c:4e06:b0:434:fddf:5c0c with SMTP id 5b1f17b1804b1-438913c60e1mr148813055e9.4.1737445566834; Mon, 20 Jan 2025 23:46:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyFH1h09pH1NiPwE1Wsrq6pqR8JPgmQvMS7dudaGRFQGkAGW4K49yhLRa/JeQy52wtjU0MWw== X-Received: by 2002:a05:600c:4e06:b0:434:fddf:5c0c with SMTP id 5b1f17b1804b1-438913c60e1mr148812775e9.4.1737445566471; Mon, 20 Jan 2025 23:46:06 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c0f03984sm174495205e9.0.2025.01.20.23.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 23:46:05 -0800 (PST) Message-ID: <543a134e-26ef-46c8-9f4e-c37e24dd7a25@redhat.com> Date: Tue, 21 Jan 2025 08:46:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-3-riel@surriel.com> <8de49f2c161085fdc63d8cc883cdebd3451df47f.camel@surriel.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8de49f2c161085fdc63d8cc883cdebd3451df47f.camel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.01.25 02:03, Rik van Riel wrote: > On Mon, 2025-01-20 at 20:47 +0100, David Hildenbrand wrote: >> On 20.01.25 03:40, Rik van Riel wrote: >>> Every pv_ops.mmu.tlb_remove_table call ends up calling >>> tlb_remove_table. >>> >> >> Indeed, but the !CONFIG_PARAVIRT variant paravirt_tlb_remove_table() >> however calls tlb_remove_page(). > > Patch 1/12 from this series removes that. > > After patch 1/12, we always call tlb_remove_table everywhere. This patch contains the hunk: -#ifndef CONFIG_PARAVIRT -static inline -void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) -{ - tlb_remove_page(tlb, table); -} -#endif - That is the source of my confusion. -- Cheers, David / dhildenb