From: Shuah Khan <skhan@linuxfoundation.org>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>,
mchehab@kernel.org, rfontana@redhat.com,
gregkh@linuxfoundation.org, allison@lohutok.net,
kstewart@linuxfoundation.org, tglx@linutronix.de
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"skh >> Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function
Date: Wed, 6 Nov 2019 11:52:42 -0700 [thread overview]
Message-ID: <543fdbda-22ca-617a-952c-3707e0b288b4@linuxfoundation.org> (raw)
In-Reply-To: <20191106183716.29170-1-dwlsalmeida@gmail.com>
On 11/6/19 11:37 AM, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
You are missing the commit message. :)
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> ---
> drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> index 4db679cb70ad..909dac2345c4 100644
> --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c
> +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> @@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;
>
> @@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;
>
> @@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void)
> state->frontend.demodulator_priv = state;
> return &state->frontend;
> }
> +EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
>
> static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = {
> .delsys = { SYS_DVBT },
> @@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = {
> MODULE_DESCRIPTION("DVB DUMMY Frontend");
> MODULE_AUTHOR("Emard");
> MODULE_LICENSE("GPL");
> -
> -EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>
next prev parent reply other threads:[~2019-11-06 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:37 Daniel W. S. Almeida
2019-11-06 18:52 ` Shuah Khan [this message]
2019-11-06 18:53 ` Fabio Estevam
2019-11-30 6:50 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543fdbda-22ca-617a-952c-3707e0b288b4@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=allison@lohutok.net \
--cc=dwlsalmeida@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®