From: "H. Peter Anvin" <hpa@zytor.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH 1/4 linux-next] x86, msr: define msr chunksize
Date: Fri, 17 Oct 2014 13:23:35 -0700 [thread overview]
Message-ID: <54417AC7.7050605@zytor.com> (raw)
In-Reply-To: <1413576089-27014-1-git-send-email-fabf@skynet.be>
On 10/17/2014 01:01 PM, Fabian Frederick wrote:
> define MSR_CHUNK_SIZE instead of hard-coded value (8).
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
I don't like the name, as it isn't a "chunk" but the actual width of an MSR.
Furthermore, the last hunk is just plain wrong; the 8 there refers to
the number of registers and not to the width of an MSR.
-hpa
prev parent reply other threads:[~2014-10-17 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 20:01 Fabian Frederick
2014-10-17 20:23 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54417AC7.7050605@zytor.com \
--to=hpa@zytor.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome