From: Jiri Slaby <jslaby@suse.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Fuqian Huang <huangfq.daxian@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] tty: rocket: Remove the rp_ioctl
Date: Wed, 17 Apr 2019 08:56:39 +0200 [thread overview]
Message-ID: <5442ab19-b0d3-74db-0055-ce425022be37@suse.cz> (raw)
In-Reply-To: <f297d82a-f1ba-c985-a2ad-397e26902e78@suse.cz>
On 17. 04. 19, 8:52, Jiri Slaby wrote:
> So could you rework the patch to remove only the one? And in a separate
> patch, introduce a printk_ratelimited warning to every "case *:" (i.e.
Not printk_ratelimited, but "dev_warn_ratelimited(tty->dev" as we have a
device.
> no warning in the "default" case) in rp_ioctl about depreciation of the
> ioctl?
>
> thanks,
--
js
suse labs
prev parent reply other threads:[~2019-04-17 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 14:53 Fuqian Huang
2019-04-17 6:27 ` Jiri Slaby
2019-04-17 6:46 ` Greg Kroah-Hartman
2019-04-17 6:52 ` Jiri Slaby
2019-04-17 6:56 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5442ab19-b0d3-74db-0055-ce425022be37@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®