From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57CEE379ECD for ; Mon, 2 Mar 2026 08:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439324; cv=none; b=uZX8js+7z4IJPDJsdXB7coC3NqVC2m4L5QMnniYQA1H/9RoqhjHD6aR+tk7P/DvITnE2uogGGVJBWWFSu8St8Y6lzamdW6jlv47JkmP3PYK51RFpnh0WaUhjILk4eejWSehCb593tpXne+MfnD/HceA8OpuozEuVvVSDGVO8S3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439324; c=relaxed/simple; bh=z/OjeLU/BgW56NOv04DU8XYhWIRJ/b3uSHrxF7ye9+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RXxYfIvAw8goMNdsIVyhl92AYtZHMjLLliybJxD2mrDshm4URccw0wOddZLqL2f7i47rPcGYDy56mTIySRwTFpo+icTnE4JKvu8QrZDqvWfIa+hreb7l3XszdtkeDhjAc1hnnR6r5xtJGOg7Kdyw8kKpyw62G6na2s5sxhcZB74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ipmP+1UO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UJ/pzdb6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ipmP+1UO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UJ/pzdb6" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6228ELNM2317812 for ; Mon, 2 Mar 2026 08:15:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1nxlvKtWHlixlnWM7lk5L+nk5CDxPToMPWa0ATJIt+U=; b=ipmP+1UOIkbkHrz5 4Zh5zcejX0AEK4qWy0UQjcCFbrK7VJKAgWA2ZJ+yrMI1JZRb+MYGUxihgsBrJdvu dvEsH9Lyyh56EIP2l2/7mw5OHLnTHNZqC10WkhgzC74NlRMcT0BEoBinGtL5Dj9H eGrnwxMXT/K9CL7f6sG8CgdUghPuGyzXdkJMoFw04R/N2URMbdxQtDe9in8qrJ51 tbqk52bdQkuOU+H9AxehKcQ/pjSxjsfc1xNC/DvenXdB2VqfLs3YaYnqy5eG5C/u wenPMG+sP7wp9rocb3lxPS5efhm3jHsVbc3cG9Lrok2jOZnioUctBTMXKlsf5411 Q9pBtw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksgrvq58-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 08:15:19 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35984ef203bso1174207a91.3 for ; Mon, 02 Mar 2026 00:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772439319; x=1773044119; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1nxlvKtWHlixlnWM7lk5L+nk5CDxPToMPWa0ATJIt+U=; b=UJ/pzdb6q8SILS0IEfKyfb9HDtcKda3+8KCiF1wYY+FX/LBmU0USoQg50iwmrKPmKH tiaZUrBGy/0ywsUdXlbONs+R2VdxA/yiS1k+tR3NsikT6MO0cNPzUOLTbNGrQS+zZEhY bXbNoZVqcac0rmTlnWD2hYFgUV3yHOWlVbxEysA7gCXJPACRHMAbj705J95RgapAKMjb jtzSC/qhTd5u7ODCn2QqeFORBspN/ZuOtOQlG0KLs974tMVBf4d/NECopDJAxg/zUmIi 7E7xtrs+JvGdIyrX1n7uEm54Ki8PiNURwgVI3UxscRGqRUxnlFRrv/qF3mtqfakj7a9k RDsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772439319; x=1773044119; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1nxlvKtWHlixlnWM7lk5L+nk5CDxPToMPWa0ATJIt+U=; b=IN4zMuFuLBDvvX2OEzhAJfSrBWKhT+ENUK/d/W/YCH8LEmihhdfyYGlZ72YHNbqHuZ e4VtS3VkSUwjxLOqY4xxTlzEADK2Wvj6Sx7+ZhomF+J3ZYANKt+6kYYIUWA/KKskbt4x /wCuCkBAkykJL7V1f8oqwt1+1DS7tAcecJvABOQtV610AbGjH2KSxqZWxncOmUj4+tYE WtFtYjTHAgMIbQ7UORpGX/6ttWUVFALGRVCjsmY5pJ1V7cIosMjeyEzvP8rXmmQyrIFb meWx5cT+7X4k7+2io4q1PABrVTmzl9OaCv3LUTLYnlYUmH6w524LmBAwUMnah+i3ZhO4 7/Vw== X-Forwarded-Encrypted: i=1; AJvYcCWVLV+GaiqNohFtdZsZt9mrlzeOX5Cu+1Okap0I1D5cj3DgdtdbVbs1wQ5qNe7drurWNVO+Eq68re6BCn0=@vger.kernel.org X-Gm-Message-State: AOJu0YzHmQDGIvr1UEh344olvysblV2r0H0gaNTXxs9Va0Dm3pcl6wOH 9U7TUXCqRnqZXFUnOy/S2aWYgtPn8gaaqHQdf5+iKfMDwZfJCt6ulTob+DXUBeWYXj3+mqRfKcT TukJX+a9qjRAsDse1LUnyJytKoDr10TLY6VDVxHi9M+UVMH+WA8ZOtu/gn88cetj7mnA= X-Gm-Gg: ATEYQzxUh2rx+EMBAtIaXrC1gAjvXzPgkKlcgtDAcdnp1gLfYuY6rxY8z6RkThSVevw Ax6IilKMGNRegrsl9cQbfoXW1AW24OFQOJKjMvrB78jOJsGmet1HAGGqvlf4fpoHYKm5+p+Li7D kqlT4QV9lWwStfN//vix+meyC9aF8NHth6pYlKezb733SVQIzWFg/BwTxBJsftE94f6JPhZNWoW 0dZgNvO6FzwXgiIzTbRN3cy6ADCHLtjJKgjGvN2PPGcgmTH5xDFua82tRcjM+CrEO9bj5B4XYfN +u6TEsJAJ5UgOkehqj57hzq6jHsmk6/m8ixxpj/Zj+oUfUG8OALhNfkK5jGNudzex2y3hUg0AIA qYfOeNA/V22Wy9H1tThd3DcvyhMTecm/EAbxAPGYuBAIndhASAA== X-Received: by 2002:a05:6300:85:b0:350:fa56:3f45 with SMTP id adf61e73a8af0-395c3b03cc5mr10176272637.35.1772439318608; Mon, 02 Mar 2026 00:15:18 -0800 (PST) X-Received: by 2002:a05:6300:85:b0:350:fa56:3f45 with SMTP id adf61e73a8af0-395c3b03cc5mr10176246637.35.1772439317962; Mon, 02 Mar 2026 00:15:17 -0800 (PST) Received: from [10.206.99.28] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa806295sm11137313a12.16.2026.03.02.00.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 00:15:17 -0800 (PST) Message-ID: <5448e807-2435-42f4-b98e-2beb6b66a6f4@oss.qualcomm.com> Date: Mon, 2 Mar 2026 13:45:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 06/18] accel/qda: Add memory manager for CB devices To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-6-fe46a9c1a046@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3MiBTYWx0ZWRfX3lrvJcStFP4M O8EWkLrDZ0a6PNc+T2+MbMN1Xo3PP5jvStEzk4a/XvviFKQB4NmVLkI+/pJ1N8kJ+MUViTcSxUG ZqeKkmN5+a8KeqgX8Mt2Ec+SKz9AcWPYwZfeTk2UG2RMY1MvrLxfKbYHZzrclkkZBxoSiFXB72M hpXN8BaFff4BdQpjsxR3l3q0IdUBA6M2aQpgJ/st9L05n4MxzYRByaLMu5XycZD7iHmKVZjukUj seK3dLjb0KTS/Az+0snK2iGQ6KQUi6aHP2/EBbMXq8aIJJ6ssMbF8+RZ7jHiHPcUhwBMcHRDUBR 9EjVLF5H8MusD1kwnJwZ6RElSrFSA36PJN3XuAQB70hR07cE3JUy/hweAFeeP2POB0kjyG3yhDU IOeQgGGvRGsPZjL3GOsiF/3nCuWborgWRJdgAGHG7VW7rIPV4VfinxZ/DRaOpRxR3N/8EzAQGtE anRMSX6L8s8WHUNRm/A== X-Proofpoint-GUID: mkyRD2Andy-fk-QD08aJdv2bMJCQBHxs X-Proofpoint-ORIG-GUID: mkyRD2Andy-fk-QD08aJdv2bMJCQBHxs X-Authority-Analysis: v=2.4 cv=Zqzg6t7G c=1 sm=1 tr=0 ts=69a54717 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=Dp_If50ftEsHmqaufPoA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020072 On 2/24/2026 4:20 AM, Dmitry Baryshkov wrote: > On Tue, Feb 24, 2026 at 12:39:00AM +0530, Ekansh Gupta wrote: >> Introduce a per-device memory manager for the QDA driver that tracks >> IOMMU-capable compute context-bank (CB) devices. Each CB device is >> represented by a qda_iommu_device and registered with a central >> qda_memory_manager instance owned by qda_dev. >> >> The memory manager maintains an xarray of devices and assigns a >> unique ID to each CB. It also provides basic lifetime management > Sounds like IDR. I was planning to stick with xarray accross QDA as IDR gives checkpatch warnings. > >> and a workqueue for deferred device removal. qda_cb_setup_device() > What is deferred device removal? Why do you need it? This is not needed, I was trying some experiment in my initial design(CB aggregation), but it's not needed now, I'll remove this. > >> now allocates a qda_iommu_device for each CB and registers it with >> the memory manager after DMA configuration succeeds. >> >> qda_init_device() is extended to allocate and initialize the memory >> manager, while qda_deinit_device() will tear it down in later >> patches. This prepares the QDA driver for fine-grained memory and >> IOMMU domain management tied to individual CB devices. >> >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/qda/Makefile | 1 + >> drivers/accel/qda/qda_cb.c | 32 +++++++ >> drivers/accel/qda/qda_drv.c | 46 ++++++++++ >> drivers/accel/qda/qda_drv.h | 3 + >> drivers/accel/qda/qda_memory_manager.c | 152 +++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_memory_manager.h | 101 ++++++++++++++++++++++ >> 6 files changed, 335 insertions(+) >>