From: Adrian Hunter <adrian.hunter@intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 05/16] perf tools: Add facility to export data in database-friendly way
Date: Fri, 24 Oct 2014 16:13:00 +0300 [thread overview]
Message-ID: <544A505C.5030203@intel.com> (raw)
In-Reply-To: <CAM9d7ci6bv_JnK8DkqqTEttPkEp1mtMPN07XjqX=K4ADOUC6SA@mail.gmail.com>
On 24/10/14 15:26, Namhyung Kim wrote:
> Hi Adrian,
>
> On Fri, Oct 24, 2014 at 7:47 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> On 24/10/14 11:11, Adrian Hunter wrote:
>>> On 24/10/14 09:02, Namhyung Kim wrote:
>>>> Can we do it somewhere in a script not in the core code? I don't feel
>>>> comfortable to add those bits into the core code. What if we export
>>>
>>> Please explain what you mean by "comfortable".
>>
>> Or rather: What about it is wrong for core code?
>
> Well, there's nothing "wrong" about it. :)
>
> But I think if some code is used only by a specific bits, it'd be
> better hiding it from the rest as much as possible.
It is pretty self-contained in db-export.[ch] and the scripting
engines.
next prev parent reply other threads:[~2014-10-24 13:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 10:45 [PATCH 00/16] perf tools: Intel PT preparation continued Adrian Hunter
2014-10-23 10:45 ` [PATCH 01/16] perf tools: Add id index Adrian Hunter
2014-10-23 21:08 ` Arnaldo Carvalho de Melo
2014-10-24 5:10 ` Namhyung Kim
2014-10-24 7:25 ` Adrian Hunter
2014-10-29 8:55 ` Jiri Olsa
2014-10-23 10:45 ` [PATCH 02/16] perf pmu: Let pmu's with no events show up on perf list Adrian Hunter
2014-10-24 5:15 ` Namhyung Kim
2014-10-24 12:57 ` Arnaldo Carvalho de Melo
2014-10-24 13:03 ` Arnaldo Carvalho de Melo
2014-10-24 13:21 ` Arnaldo Carvalho de Melo
2014-10-24 14:36 ` Adrian Hunter
2014-10-24 14:38 ` Adrian Hunter
2014-10-24 14:45 ` Arnaldo Carvalho de Melo
2014-10-24 15:35 ` Arnaldo Carvalho de Melo
2014-10-30 6:45 ` [tip:perf/core] perf pmu: Let pmu' s " tip-bot for Adrian Hunter
2014-10-23 10:45 ` [PATCH 03/16] perf session: Add perf_session__deliver_synth_event() Adrian Hunter
2014-10-24 5:22 ` Namhyung Kim
2014-10-24 10:41 ` Adrian Hunter
2014-10-23 10:45 ` [PATCH 04/16] perf tools: Add a thread stack for synthesizing call chains Adrian Hunter
2014-10-23 20:51 ` Arnaldo Carvalho de Melo
2014-10-24 8:47 ` Adrian Hunter
2014-10-24 5:41 ` Namhyung Kim
2014-10-29 9:03 ` Jiri Olsa
2014-10-29 9:07 ` Jiri Olsa
2014-10-23 10:45 ` [PATCH 05/16] perf tools: Add facility to export data in database-friendly way Adrian Hunter
2014-10-23 21:42 ` Arnaldo Carvalho de Melo
2014-10-24 6:02 ` Namhyung Kim
2014-10-24 8:11 ` Adrian Hunter
2014-10-24 10:47 ` Adrian Hunter
2014-10-24 12:26 ` Namhyung Kim
2014-10-24 13:13 ` Adrian Hunter [this message]
2014-10-24 14:40 ` Arnaldo Carvalho de Melo
2014-10-24 14:41 ` Arnaldo Carvalho de Melo
2014-10-30 6:46 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-10-23 10:45 ` [PATCH 06/16] perf tools: Extend Python script interface to export data in a " Adrian Hunter
2014-10-30 6:47 ` [tip:perf/core] perf scripting python: Extend " tip-bot for Adrian Hunter
2014-10-23 10:45 ` [PATCH 07/16] perf tools: Add Python script to export to postgresql Adrian Hunter
2014-10-30 6:47 ` [tip:perf/core] perf script: " tip-bot for Adrian Hunter
2014-10-23 10:45 ` [PATCH 08/16] perf tools: Add branch type to db export Adrian Hunter
2014-10-23 10:45 ` [PATCH 09/16] perf tools: Add branch_type and in_tx to Python export Adrian Hunter
2014-10-23 10:45 ` [PATCH 10/16] perf tools: Enhance the thread stack to output call/return data Adrian Hunter
2014-10-29 13:23 ` Jiri Olsa
2014-10-29 14:02 ` Arnaldo Carvalho de Melo
2014-10-23 10:45 ` [PATCH 11/16] perf tools: Add call information to the database export API Adrian Hunter
2014-10-23 10:45 ` [PATCH 12/16] perf tools: Add call information to Python export Adrian Hunter
2014-10-23 10:45 ` [PATCH 13/16] perf tools: Defer export of comms that were not 'set' Adrian Hunter
2014-10-23 10:45 ` [PATCH 14/16] perf tools: Build programs to copy 32-bit compatibility VDSOs Adrian Hunter
2014-10-30 6:45 ` [tip:perf/core] perf tools: Build programs to copy 32-bit compatibility tip-bot for Adrian Hunter
2014-10-23 10:45 ` [PATCH 15/16] perf tools: Add support for 32-bit compatibility VDSOs Adrian Hunter
2014-10-30 6:45 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-10-23 10:45 ` [PATCH 16/16] perf tools: Do not attempt to run perf-read-vdso32 if it wasn't built Adrian Hunter
2014-10-30 6:46 ` [tip:perf/core] " tip-bot for Adrian Hunter
2014-10-23 21:11 ` [PATCH 00/16] perf tools: Intel PT preparation continued Arnaldo Carvalho de Melo
2014-10-23 23:43 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A505C.5030203@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome