From: Jeff Mahoney <jeffm@suse.com>
To: Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Peter Foley <pefoley2@pefoley.com>
Subject: [PATCH] vdso: don't require 64-bit math in standalone test
Date: Fri, 24 Oct 2014 14:48:58 -0400 [thread overview]
Message-ID: <544A9F1A.4050303@suse.com> (raw)
The use of 64-bit math on i386 causes build failures:
vdso_standalone_test_x86.c:(.text+0x101): undefined reference to `__umoddi3'
vdso_standalone_test_x86.c:(.text+0x12d): undefined reference to `__udivdi3'
Commit adb19fb66ee (Documentation: add makefiles for more targets) is
now building this by default, so it's failing the kernel build entirely.
Switching the declaration from uint64_t to time_t does the right thing
and handles the x32 case automatically.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
Documentation/vDSO/vdso_standalone_test_x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/Documentation/vDSO/vdso_standalone_test_x86.c
+++ b/Documentation/vDSO/vdso_standalone_test_x86.c
@@ -63,7 +63,7 @@ static inline void linux_exit(int code)
x86_syscall3(__NR_exit, code, 0, 0);
}
-void to_base10(char *lastdig, uint64_t n)
+void to_base10(char *lastdig, time_t n)
{
while (n) {
*lastdig = (n % 10) + '0';
--
Jeff Mahoney
SUSE Labs
next reply other threads:[~2014-10-24 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 18:48 Jeff Mahoney [this message]
2014-10-24 18:56 ` Peter Foley
2014-10-24 19:12 ` Randy Dunlap
2014-10-25 14:56 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A9F1A.4050303@suse.com \
--to=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pefoley2@pefoley.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome