From: "Jan Beulich" <JBeulich@suse.com>
To: <mingo@kernel.org>
Cc: <tglx@linutronix.de>, <jiang.liu@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
Date: Tue, 28 Oct 2014 13:47:59 +0000 [thread overview]
Message-ID: <544FAC9F0200007800042CA6@mail.emea.novell.com> (raw)
In-Reply-To: <tip-a425cf83e39f99a70168c184e79cea8c67ba7c12@git.kernel.org>
>>> On 28.10.14 at 12:18, <tipbot@zytor.com> wrote:
> Commit-ID: a425cf83e39f99a70168c184e79cea8c67ba7c12
> Gitweb: http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12
> Author: Jan Beulich <JBeulich@suse.com>
> AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 28 Oct 2014 12:01:09 +0100
>
> ix86: Fix build failure when !CONFIG_X86_IO_APIC
>
> mp_should_keep_irq() isn't really IO-APIC related, and
> considering that it's being used solely in arch/x86/pci/ likely
> both declaration and definition got misplaced even without
> considering the resulting build failure:
>
> .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
> .../arch/x86/pci/irq.c:1259: error: implicit declaration of function
> ‘mp_should_keep_irq’
> make[3]: *** [arch/x86/pci/irq.o] Error 1
>
> Move them to better places.
Ingo,
the build failure had got addressed by a different patch already,
albeit that patch seems far from ideal to me. I.e. I still think cleanup
along the lines of the patch here is desirable, but I need to submit
one that actually builds (the build failure the test robot encountered
is a direct result of the clash between the two patches). I have that
patch ready, but didn't want to submit before I got around to test it
with 3.18-rc.
Jan
next prev parent reply other threads:[~2014-10-28 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 12:44 [PATCH] ix86: fix " Jan Beulich
2014-10-28 11:13 ` [tip:x86/urgent] ix86: Fix " tip-bot for Jan Beulich
2014-10-28 11:18 ` tip-bot for Jan Beulich
2014-10-28 13:47 ` Jan Beulich [this message]
2014-10-29 7:50 ` Ingo Molnar
2014-10-29 7:53 ` Jan Beulich
2014-10-29 7:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FAC9F0200007800042CA6@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®