From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A36433E79 for ; Thu, 16 Jul 2026 17:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784222683; cv=none; b=TBoX3+2I2foeb39d7cG1Uj6P8PqV2TKuQqbVseKo6C+CaaT2OsClqgip7XuD+OJ2cHTtSBvunpnDlpDEzABRKGKZiYvWkYo/MGgOXdORfXqkOUpnqoPSBTiv/4iZGWBr6jjKpcimZXnEjv2Lm0+tUkiMg6kFSYIZTZpuA65+Td8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784222683; c=relaxed/simple; bh=MGezBw6L/N2P7majkjEUq3jbpgpgj2L0JiCmDuCi8y8=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=QfgXg6enFpB7w12pTJjoBRml/Ty8ZHL0WNK7sYh6I2bv2p8xIp1cuVuiOaStLyjXhP4dmJWKjtKnz5WQJnzCaEADaQciMXLkRhKQBmGxlvTzn/7e7xRko4Dbco+/jsmpy/RHToMZUjg8GmwzTxy5a7JDU73kdw9hfV1iI2Th2+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b=kf8IX1iV; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b="kf8IX1iV" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-81e86df8987so9619277b3.3 for ; Thu, 16 Jul 2026 10:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20251104.gappssmtp.com; s=20251104; t=1784222680; x=1784827480; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=L8pbCIS5VqFPHr1kZm8UluOHfD6jnfTXYimRQ16f+8g=; b=kf8IX1iV26OdlluMKhYcQqjDFqvS784PLT8EBYUNLpxW4aPw+Uj045gyf7I1eqN1ao BwZPIyDdovA3oragxSQQQEZpr5cNgCGWxbGgtn4jew6V9rjqu3Ov5T9ojX4lh9woG6Q5 FYGKTm8lKf7NXAkFR3Yrnc0PgpsMoR78H0GWL51mQk1mqFcg2ANDjaGU7QmIEXyZFAte WpufjHMMDOtCflxJULSogJxpjpRE6p2L0HtFHRwq29bOLG3hvpMjdrejEh3JQbcOUDoK 2d23xl1VrLmgs1F1y/Le7ihzpLMsWrvyWC04dk/qGE9TVe5PMDqhIMt2EFwejY2Mg2Ya vP1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784222680; x=1784827480; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=L8pbCIS5VqFPHr1kZm8UluOHfD6jnfTXYimRQ16f+8g=; b=e8xPnPjaNICSB8f4PrrA5UiEkuADS++y9q1C8rdqdoX9gyUm6972Ix3eMvXDWS5TlQ uQWbpOQwVUOPYnuxT5Nhanm5gpr7zbCtl1gjH4oY5OaXATfwlc+0Cj78s0a8PErLpFFN WYQOplby2qociF6sHaIzBSb/ccck3ULvFpc8EqOVDVNjkt39NvT3e2B41ScmeKcK8rxH zzc4RRhIbCOBPMts9nRGnd+nFk4F5vaBFHqI/f8LUNSeqGRBju4HebY0a44ta8Xluhuw gHlNar42uqUZJz+UZ0upbFwGNWjMmvx+xyZVlJ59NdElbFaFkLt3vwrmQhaVDMTPhOFK 4bBw== X-Forwarded-Encrypted: i=1; AHgh+RrFH73W+XZv40m++ix0Z3c7/NipL01ihyw2rVbAnAz93Hu98E+yo0CfgTdOy/zcxDSNsGV43kjOrZzfWHo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl72J7gnf88L/O8ZAerCGfdL7+JwHZvQVXi5sAjPtnqEmHwU/q FpajtkdqtXUc4quxzkVdbzbP3sX9X9mI7P7xdlTC0q8rrOzMuw0yYo3EgPqQ1rxh9hpPyN81oJa 6YgM8n8u7wg== X-Gm-Gg: AfdE7cnJYuZiAo8w80td38D8RnvTKheFBONRrrybZyZRBlvh5wr56pVSHK6ALWqaLee gBuEghnsiRFUJRgvxS6wxbx7bkBx8RuRXa/8/ffISIb/IRdtyNk9jkebzzSNccUPlkynUew7BwM Q30w3tG2plHK46Sk9SndXmhRAxwchg/MTQVSvzGRaoZr5tNIuYEHjQJvgVUzbDMSs6VL+CCm1/p bHB5nKva+juYSyvp0PYo1kcMj2lqaZxITwPpvaIsquhJdkEI2BWJ5foR+kxzM6II9/zjNrYUoUH uNnKNo4KuZwE1GQYcCxm9+VroPSHs3lbtemS4NLaZOxIrkkBJlox/nCEIULlJ6MU6TSAK4jrmTq 5jrX5antZ2fu8tTjyh2c/8wtiVB2NBdwDbMncA1c7AQJQ4j0JDzXhUzhpngCJmv0gEzM9kNhAOw F5TFRViuebbmvDCB5Y3KdcMYAepWgwGjTWkUYXx+jGLvRsjMObBiBLWxrlOR/DNj2SBjGzW/pYY Sb/wBttDdXjdAFEGRIaOdZOPVWtxXNWpHqvstOB4oSG/zQ/+96wk2VvBiVLGA8c/E0qVjs= X-Received: by 2002:a05:690c:9b0e:b0:806:5a1c:d892 with SMTP id 00721157ae682-81ecfa136e6mr64858037b3.47.1784222680322; Thu, 16 Jul 2026 10:24:40 -0700 (PDT) Received: from ?IPv6:2600:1700:6476:1430:1ec9:9caa:73bc:e646? ([2600:1700:6476:1430:1ec9:9caa:73bc:e646]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e950567eesm140320917b3.13.2026.07.16.10.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 10:24:39 -0700 (PDT) Message-ID: <544d89dcd4303cde366537744fb2182ebc1622ba.camel@dubeyko.com> Subject: Re: [PATCH] fix: release unused ceph cap reservation on readdir error From: Viacheslav Dubeyko To: deepakroag , Ilya Dryomov , Alex Markuze , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 16 Jul 2026 10:24:38 -0700 In-Reply-To: <20260715181612.18192-1-gaikwad.dcg@gmail.com> References: <20260715181612.18192-1-gaikwad.dcg@gmail.com> Autocrypt: addr=slava@dubeyko.com; prefer-encrypt=mutual; keydata=mQINBGgaTLYBEADaJc/WqWTeunGetXyyGJ5Za7b23M/ozuDCWCp+yWUa2GqQKH40dxRIR zshgOmAue7t9RQJU9lxZ4ZHWbi1Hzz85+0omefEdAKFmxTO6+CYV0g/sapU0wPJws3sC2Pbda9/eJ ZcvScAX2n/PlhpTnzJKf3JkHh3nM1ACO3jzSe2/muSQJvqMLG2D71ccekr1RyUh8V+OZdrPtfkDam V6GOT6IvyE+d+55fzmo20nJKecvbyvdikWwZvjjCENsG9qOf3TcCJ9DDYwjyYe1To8b+mQM9nHcxp jUsUuH074BhISFwt99/htZdSgp4csiGeXr8f9BEotRB6+kjMBHaiJ6B7BIlDmlffyR4f3oR/5hxgy dvIxMocqyc03xVyM6tA4ZrshKkwDgZIFEKkx37ec22ZJczNwGywKQW2TGXUTZVbdooiG4tXbRBLxe ga/NTZ52ZdEkSxAUGw/l0y0InTtdDIWvfUT+WXtQcEPRBE6HHhoeFehLzWL/o7w5Hog+0hXhNjqte fzKpI2fWmYzoIb6ueNmE/8sP9fWXo6Av9m8B5hRvF/hVWfEysr/2LSqN+xjt9NEbg8WNRMLy/Y0MS p5fgf9pmGF78waFiBvgZIQNuQnHrM+0BmYOhR0JKoHjt7r5wLyNiKFc8b7xXndyCDYfniO3ljbr0j tXWRGxx4to6FwARAQABtCZWaWFjaGVzbGF2IER1YmV5a28gPHNsYXZhQGR1YmV5a28uY29tPokCVw QTAQoAQQIbAQUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFXDC2tnzsoLQtrbBDlc2cL fhEB1BQJoGl5PAhkBAAoJEDlc2cLfhEB17DsP/jy/Dx19MtxWOniPqpQf2s65enkDZuMIQ94jSg7B F2qTKIbNR9SmsczjyjC+/J7m7WZRmcqnwFYMOyNfh12aF2WhjT7p5xEAbvfGVYwUpUrg/lcacdT0D Yk61GGc5ZB89OAWHLr0FJjI54bd7kn7E/JRQF4dqNsxU8qcPXQ0wLHxTHUPZu/w5Zu/cO+lQ3H0Pj pSEGaTAh+tBYGSvQ4YPYBcV8+qjTxzeNwkw4ARza8EjTwWKP2jWAfA/ay4VobRfqNQ2zLoo84qDtN Uxe0zPE2wobIXELWkbuW/6hoQFPpMlJWz+mbvVms57NAA1HO8F5c1SLFaJ6dN0AQbxrHi45/cQXla 9hSEOJjxcEnJG/ZmcomYHFneM9K1p1K6HcGajiY2BFWkVet9vuHygkLWXVYZ0lr1paLFR52S7T+cf 6dkxOqu1ZiRegvFoyzBUzlLh/elgp3tWUfG2VmJD3lGpB3m5ZhwQ3rFpK8A7cKzgKjwPp61Me0o9z HX53THoG+QG+o0nnIKK7M8+coToTSyznYoq9C3eKeM/J97x9+h9tbizaeUQvWzQOgG8myUJ5u5Dr4 6tv9KXrOJy0iy/dcyreMYV5lwODaFfOeA4Lbnn5vRn9OjuMg1PFhCi3yMI4lA4umXFw0V2/OI5rgW BQELhfvW6mxkihkl6KLZX8m1zcHitCpWaWFjaGVzbGF2IER1YmV5a28gPFNsYXZhLkR1YmV5a29Aa WJtLmNvbT6JAlQEEwEKAD4WIQRVwwtrZ87KC0La2wQ5XNnC34RAdQUCaBpd7AIbAQUJA8JnAAULCQ gHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA5XNnC34RAdYjFEACiWBEybMt1xjRbEgaZ3UP5i2bSway DwYDvgWW5EbRP7JcqOcZ2vkJwrK3gsqC3FKpjOPh7ecE0I4vrabH1Qobe2N8B2Y396z24mGnkTBbb 16Uz3PC93nFN1BA0wuOjlr1/oOTy5gBY563vybhnXPfSEUcXRd28jI7z8tRyzXh2tL8ZLdv1u4vQ8 E0O7lVJ55p9yGxbwgb5vXU4T2irqRKLxRvU80rZIXoEM7zLf5r7RaRxgwjTKdu6rYMUOfoyEQQZTD 4Xg9YE/X8pZzcbYFs4IlscyK6cXU0pjwr2ssjearOLLDJ7ygvfOiOuCZL+6zHRunLwq2JH/RmwuLV mWWSbgosZD6c5+wu6DxV15y7zZaR3NFPOR5ErpCFUorKzBO1nA4dwOAbNym9OGkhRgLAyxwpea0V0 ZlStfp0kfVaSZYo7PXd8Bbtyjali0niBjPpEVZdgtVUpBlPr97jBYZ+L5GF3hd6WJFbEYgj+5Af7C UjbX9DHweGQ/tdXWRnJHRzorxzjOS3003ddRnPtQDDN3Z/XzdAZwQAs0RqqXrTeeJrLppFUbAP+HZ TyOLVJcAAlVQROoq8PbM3ZKIaOygjj6Yw0emJi1D9OsN2UKjoe4W185vamFWX4Ba41jmCPrYJWAWH fAMjjkInIPg7RLGs8FiwxfcpkILP0YbVWHiNAabQoVmlhY2hlc2xhdiBEdWJleWtvIDx2ZHViZXlr b0BrZXJuZWwub3JnPokCVAQTAQoAPhYhBFXDC2tnzsoLQtrbBDlc2cLfhEB1BQJoVemuAhsBBQkDw mcABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEDlc2cLfhEB1GRwP/1scX5HO9Sk7dRicLD/fxo ipwEs+UbeA0/TM8OQfdRI4C/tFBYbQCR7lD05dfq8VsYLEyrgeLqP/iRhabLky8LTaEdwoAqPDc/O 9HRffx/faJZqkKc1dZryjqS6b8NExhKOVWmDqN357+Cl/H4hT9wnvjCj1YEqXIxSd/2Pc8+yw/KRC AP7jtRzXHcc/49Lpz/NU5irScusxy2GLKa5o/13jFK3F1fWX1wsOJF8NlTx3rLtBy4GWHITwkBmu8 zI4qcJGp7eudI0l4xmIKKQWanEhVdzBm5UnfyLIa7gQ2T48UbxJlWnMhLxMPrxgtC4Kos1G3zovEy Ep+fJN7D1pwN9aR36jVKvRsX7V4leIDWGzCdfw1FGWkMUfrRwgIl6i3wgqcCP6r9YSWVQYXdmwdMu 1RFLC44iF9340S0hw9+30yGP8TWwd1mm8V/+zsdDAFAoAwisi5QLLkQnEsJSgLzJ9daAsE8KjMthv hUWHdpiUSjyCpigT+KPl9YunZhyrC1jZXERCDPCQVYgaPt+Xbhdjcem/ykv8UVIDAGVXjuk4OW8la nf8SP+uxkTTDKcPHOa5rYRaeNj7T/NClRSd4z6aV3F6pKEJnEGvv/DFMXtSHlbylhyiGKN2Amd0b4 9jg+DW85oNN7q2UYzYuPwkHsFFq5iyF1QggiwYYTpoVXsw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-07-15 at 23:46 +0530, deepakroag wrote: > Return unused reserved caps to the MDS client pool when > ceph_readdir_prepopulate() exits with an error. >=20 > Corrected standalone submission: this patch was mistakenly > sent earlier as [PATCH 4/4] in an unrelated multi-subsystem > series.=C2=A0 It is ceph-only and resubmitted here as [PATCH 1/1]. Frankly speaking, it will be better to explain the issue detection and analysis here. >=20 > Link: > https://lore.kernel.org/ceph-devel/20260715143646.15828-4-gaikwad.dcg@gma= il.com/ >=20 > Signed-off-by: deepakroag > --- > =C2=A0fs/ceph/inode.c | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c > index 61d7c0b81..2d6a80054 100644 > --- a/fs/ceph/inode.c > +++ b/fs/ceph/inode.c > @@ -2188,6 +2188,8 @@ int ceph_readdir_prepopulate(struct > ceph_mds_request *req, > =C2=A0 dput(dn); > =C2=A0 } > =C2=A0out: > + if (err) > + ceph_unreserve_caps(req->r_mdsc, &req- > >r_caps_reservation); > =C2=A0 if (err =3D=3D 0 && skipped =3D=3D 0) { > =C2=A0 set_bit(CEPH_MDS_R_DID_PREPOPULATE, &req- > >r_req_flags); > =C2=A0 req->r_readdir_cache_idx =3D cache_ctl.index; OK. So, we need to do this because handle_reply() [1] execute this after ceph_readdir_prepopulate(): if (err =3D=3D 0) { ... ceph_unreserve_caps(mdsc, &req->r_caps_reservation); } However, we are missing another execution branch [2]: if (test_bit(CEPH_MDS_R_ABORTED, &req->r_req_flags)) return readdir_prepopulate_inodes_only(req, session); I believe that we need to improve the patch. Thanks, Slava. [1] https://elixir.bootlin.com/linux/v7.2-rc3/source/fs/ceph/mds_client.c#L4186 [2] https://elixir.bootlin.com/linux/v7.2-rc3/source/fs/ceph/inode.c#L2017