From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB2A3CEBBB for ; Wed, 25 Mar 2026 11:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774438598; cv=none; b=rNADM9qHPWqRtd2hy5eAuRswTTOu1+5IuTE7qoIlakl27MapA9mCQIzr3k1DiMNeIzYOyaIzUxhwKZBnJ2kvW1UTHGlIjCIBnYsoLVidcawjgMLFmHwnOTIDd+DgLrC4st084zO+y87hZss6IttzLnqSxO0ev6MKhihan3vYFNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774438598; c=relaxed/simple; bh=z+8i3GYxmPysMPaCb7ZxvnZe2fGGVA4EZxOB9hfujIU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XNPJzISDyoyrcOgGsnKT03p7QnS0X92xjpkJuJaBQssrOWKvZoQVU9ZZTPrD3k9LcA5yrjTuLRieYtw9EbyCDHIUnMbBWUCdTR+2zPMepZHf1b/ywPmA4A8/WRVgD9a7CUa1u5rNJUBTbqRCXXFmVBgG22Y+ZfyS6AWDDkXvEYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fivO+lZt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LdL4ybDU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fivO+lZt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LdL4ybDU" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PBG1b9720564 for ; Wed, 25 Mar 2026 11:36:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DCdNH+n+g6mJ9mJTkyKqJkhT1JA5zvNKqGn8D4J1dYg=; b=fivO+lZtWQ3iroMH Czs7q6AyDLwyV0ZJVVbIywxPWiA1c/F2Qz8tVdRekRFKX7Wd+NIXGwRMteFbPAF9 WwSuQ5BhHBw4jylxharxZ1bG49i19d8B+YWeaFFRWljBEpzt8Iw8DHT2WhtEOZz5 KQBOYkd/5iX5ru5qfDl8Cm0kxZvVCcXCyZ6ohF8zyY291GFiHV33/Upw1k3MinE8 LDXh5MAaxgVxACL9P2u/D9Ao5KBFM+PtG1WWOqSmDKeEoA/ZhqY/mAcmV7+hzCGZ Lc6o3Dn0ukUqC1vYudr2TUB9sCdZhIG//CaGKnFlyt2t6WQ2/tBXWEwukHeF7E1Z MgqTaw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4dm2ran0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 11:36:36 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5091782ab06so309346951cf.0 for ; Wed, 25 Mar 2026 04:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774438595; x=1775043395; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DCdNH+n+g6mJ9mJTkyKqJkhT1JA5zvNKqGn8D4J1dYg=; b=LdL4ybDU46khP4GsIkNocBsQRMD7pC53oQJPIjfvQwG8U1+sdIBlvqPU4Ncce8WBZH U2MXjGn86Xm6zij8/sWoVIUBUAQIaTv6SQM9TCFazwt44xP/hsnIKKbtfgQOliQe5C7H POSHhWd0h0UPHe+ucQghZtcRiYtpOg3d403sy/q2leWgQELsBPJmS1e4Yh+/aYhCXx+Y mnD56WrbF86anLy9kcIe5UwkSv/os9LyoMAN0QGbbP05fUroJi/nHw3rgvrW4IO4vLTx TOmqtmitwM4nrML09EKL0Egl2Y1ee0EqxzTOyE2qqqgBwS6d9HwuOawqASc/FXkWYkbh Ex5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774438595; x=1775043395; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DCdNH+n+g6mJ9mJTkyKqJkhT1JA5zvNKqGn8D4J1dYg=; b=L1p6fUzDmUtjC+Xj8DVGd3YPexm8YfdSugSgd01xrFkRBTbu3clqq50fIpBmhX5x38 60cIChdT8xfnY+V36fc+czXWpTgvqE263cCfGL4tGRXGRBDbnhCTeo6bnYaZbgPafy+0 u6Ds/HWEsvCH3I3SYhaJCMVMLpQkaXSi8FSBeUjZqhcT0Q0PReJKrTmAPTNxsWOh5zvA 2hanHPxsrupl8Uqhuqdd6coSy6d9MKryn0+/VsxWuPalJf1AYGCDLK5Ps0vuf+uH2hlm oTa3nHCJBdsuT3cz8p4ms2g4xCxpiUoe723bZ5StmpLyPx+SkKZixOmqhPuB/vMsVWRB ZJKQ== X-Forwarded-Encrypted: i=1; AJvYcCXzdKKhrhGZB5T4U3d59EdV1sPWUiMVb4OL24wRjSi8CxfIrGskqOyadXsiwhlI7/k/+h97IO0jNlxzo+4=@vger.kernel.org X-Gm-Message-State: AOJu0YykQZBlqBUsL9umfs1proRt71hYKzVRZxi8mpBdXMIsrM7QjdNN ids9AaJRn8End+JCfmUysW0rUhgxwqDsWMLlXi9m8Sj0L+bwetCIASN4veGrOhD0pZe2muzm+dS JZp6Z/V6QTmruBQmOgMni+bMRQpIjnXT2cg9XFMrNqMXGpwYft8e+zjdfF4qtwv7C2ag= X-Gm-Gg: ATEYQzwuH4WLQpb+xQTk4t1qbZ8IS8nqx1zwbMf+cQAphrYV3ja6EAEbTWpTjU+oHG3 iPMWf1q2JRJdSLVS4j0pu1+M52vNroCIv+VuprUIpKrvzESRl3wln2gXshq4ADaBdjkspyZZS8/ nX7gViCpm2ZG09gfQCJP2fsxQgforoU7zyfvjI/GJA+wMTYF0FLBC9FzZmPe01UHUThb3TYXup8 xMxbGU0XsDGrPEfcmABcfI8IUVDF8JF4tx6wMrocAH7MkDJjKrdy46S6v20Z6n9YjJlEkyiKire VLZHeZ9jl9jOWQ7xNZ6kebbvF8Bh8ejkU2hGinAoV3apSuBHLtCWxHpUDRWAa+OWJJf/jfXRr76 OLLa/E1+1EirK00WaNbDP3lpwemfw3HvluAu3kmFp7/x4p4ja X-Received: by 2002:ac8:5a95:0:b0:50b:4491:a2c1 with SMTP id d75a77b69052e-50b80e90f59mr47306611cf.63.1774438595526; Wed, 25 Mar 2026 04:36:35 -0700 (PDT) X-Received: by 2002:ac8:5a95:0:b0:50b:4491:a2c1 with SMTP id d75a77b69052e-50b80e90f59mr47306041cf.63.1774438595091; Wed, 25 Mar 2026 04:36:35 -0700 (PDT) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-487172f909asm25777975e9.6.2026.03.25.04.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 04:36:34 -0700 (PDT) Message-ID: <544debd5-bb7c-4b89-8641-eb63a107155b@oss.qualcomm.com> Date: Wed, 25 Mar 2026 11:36:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/13] ASoC: qcom: q6apm: move component registration to unmanaged version To: Mark Brown , Srinivas Kandagatla Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com References: <20260323223845.2126142-1-srinivas.kandagatla@oss.qualcomm.com> <20260323223845.2126142-2-srinivas.kandagatla@oss.qualcomm.com> <981a6253-5005-4281-88fb-3ef6361dfb76@sirena.org.uk> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <981a6253-5005-4281-88fb-3ef6361dfb76@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA4MiBTYWx0ZWRfX45ne3D8vE29x UXN+m7xhuJm/7u7IdRegGULgU9s5TbZM3uGMU3Ma4NVU9gAms7mPX5u02xexJTrixd2n42e61aG tBXSNgrGt8v47lfJJye2GuxRuGCkoeJDtL7QFmRtree9fnZxkOHaOuroCGZQeoNK7fTeF2xt5NY kKerei5rDxZJ/CbBMMi3jJJyGBq8OkQ1OpQQRE9FEGXPNF9i9b0GK8kwqzRGHg8KAgrkLFaSpy4 tuUrg14ruBXm4KanXKg1Z5YVTRl3THJyvYvzEVJ8UydK3ZnG7E5A30s0b3z1c50OKdGdc2cs0z2 6DC6yAGF2IIAwbHTBd7TBAL0GhVbFGPpUT3dIri/gTXzUcdXk2gKBkjLmeeFf2UxzRsGRdzUzmi +ogJUiuZZSqmyL6My2HICl+6VgYbVmO8dhiNy6zdMqSKdKCOjJNb2zZiYoAcgZFGhxrcaD/bqKc PbETBiYdSdnDmBuLd5A== X-Proofpoint-GUID: qoNqnVhjoHcYpbIZOd7IWPJ-KUzVZP9d X-Authority-Analysis: v=2.4 cv=Fo0IPmrq c=1 sm=1 tr=0 ts=69c3c8c4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=3rt7OP6hf4PjYIihl4UA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: qoNqnVhjoHcYpbIZOd7IWPJ-KUzVZP9d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_04,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250082 On 3/24/26 6:04 PM, Mark Brown wrote: > On Mon, Mar 23, 2026 at 10:38:33PM +0000, Srinivas Kandagatla wrote: > >> --- a/sound/soc/qcom/qdsp6/q6apm.c >> +++ b/sound/soc/qcom/qdsp6/q6apm.c >> @@ -747,7 +747,7 @@ static int apm_probe(gpr_device_t *gdev) >> >> q6apm_get_apm_state(apm); >> >> - ret = devm_snd_soc_register_component(dev, &q6apm_audio_component, NULL, 0); >> + ret = snd_soc_register_component(dev, &q6apm_audio_component, NULL, 0); >> if (ret < 0) { >> dev_err(dev, "failed to register q6apm: %d\n", ret); >> return ret; >> @@ -756,6 +756,11 @@ static int apm_probe(gpr_device_t *gdev) >> return of_platform_populate(dev->of_node, NULL, NULL, dev); >> } > > Given that of_platform_populate() can fail we now need unwinding for the Yes, will fix that in next spin. --srini > component registration here with the removal of devm_