From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D63AE3AFB03 for ; Wed, 24 Jun 2026 12:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782305121; cv=none; b=ZhzFiEPgR6PLskUlGI/hSYPQQRDkJPdb5sZNK6lQRD3Rgqt+kXpU1Kwxuq2lYtZ41Dcc/seXhbzVaid2KDuN91PHP+zsVfnsNmvmrb6EA312ZvGbuwtPAFtYoFXleXa0zTEx01RkoraGRIHgSMOcg6n1Tw8F6gSZ0K2E8QehR+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782305121; c=relaxed/simple; bh=wburqNFqddDcYvdONGTxV4jyyRCt4GMG3P5jYMC/uQU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s4tpGOEMmrRFAIaCKu+Cxoix3g1+ZV0HA7CHOUdrjKcSZRXUtpjhlEpU/yy8V2YRAHzOKw7IwAn6NVW5iWNRMg2kXxNEYRlx1jovY7aaD6XX+jUOauu/yZic9ZGlVFnCEBz683PiiVnoyxN5XzTXGmO4HZ/gH80idHAyt+aML70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bynar.io; spf=pass smtp.mailfrom=bynar.io; dkim=pass (2048-bit key) header.d=bynar.io header.i=@bynar.io header.b=g8UnBYe4; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bynar.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bynar.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bynar.io header.i=@bynar.io header.b="g8UnBYe4" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-697e96dd8d2so2132568a12.1 for ; Wed, 24 Jun 2026 05:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bynar.io; s=google; t=1782305118; x=1782909918; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wburqNFqddDcYvdONGTxV4jyyRCt4GMG3P5jYMC/uQU=; b=g8UnBYe4DpFOrOHE0+e+n85LeCxJn9CRwTN21XlN4/x8vsJK5vdpHt3TPQfDLMLesM ra8JRLzVAnkWxFynqU/k3w56oaaWIZy2tWjjYI3ziBLlv/NoVF1VRL58zEEYxzB34M+X ZYMkMIDLa5eqZPp/L74JX5VNDVV0dD6Sx9VR1jPSvjVW+ji+WCPUVsez8huiof6YzIpQ eV3EzAiEYIpve8b2bd7hqCrA5PO8r0dcQpKg9b5GcBFN7j//cq5QPJZxKYMOziTqmhmj DRMdCp5kqwwzYK8U7TrzrT6aNH4xrw5DCRNjNGLF/nKWINt4/9yOs2fv6rzHT48GA3XC RuTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782305118; x=1782909918; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wburqNFqddDcYvdONGTxV4jyyRCt4GMG3P5jYMC/uQU=; b=Je3Z0BBslcumzQxc7qV39lNEtmpG3XcZPN/khYVfkdPaph4J2c39ddX9jiHTFGWHNc 2McPjkjMVm+BcbGyaDmrTXc6/gYU/xYzp/G6alJ8t3TU9wXEoM/0zT/R60oQitx8fO+2 BUPnVVvq5KBVtHw1ENqVvE1bkRmNAFIgN8CcPv1Ra626wak6mw5MVqrKnHEB59FCeEv5 Xe3sAchH5oJIKPZTgoaKpckVQKB6f8gOhk9X61ocjRqxehW8oDDV7PvaONrWtdYKmYXZ XZXfsDjViKfe/0SfKoA9BV9B06TK2RCd2JDIvx+70+KqWB7EQ2BuVodG0fmAtogT2pKe vNHg== X-Forwarded-Encrypted: i=1; AFNElJ+xda46573g3IeMwhXQeCXi8t4IFlPn+U1S2c+6AWUN5TAG+X9wJUZyhU6XVQrhI6K+lVsvcABWYXjd08M=@vger.kernel.org X-Gm-Message-State: AOJu0YypX38uJn7F7gJM3YSHniU+K0upSC5BoUbHWd/HVC/dAp15Rp5y RhtPvSjBDvqnKM0mv1othmtshZwsatttmfs0YOSzNi2FBMh9ZgG+kvQSuYQl0zz8FUup X-Gm-Gg: AfdE7ckSCaYQdybkjoFvM+gCcThHoFpDIHUBxdmn8tf8GHJh96UgLbOG7nLfQVSfMiF LQSMSNJBidkdNgZXFGJky0VPqazyIO1NcvZThvWqMLNK9kdMUZlnJSvp8IDyTtVOm5uaHsGgsc2 5NyemDpXsSWTc+FFGdSfCmKWcDFTY1jPHuFqnlysGOZ/nfOKy/NWRrplHm2tFcsFFhKXgQlLCYm TOwzKZPwA2R/LSRagfYdY1Sf8mEwP/7QRXyEdcxZgAdO35vDnEA7xnR3btGMzsfJ0+gvN2fryHO TrmH4eOIDku5tf2feS9SIUFrKe3F6AzFTt3ifGRaKTiQuW0r8fYETAxtDAe4bAl37U25imO1LyB tc23QsP/chzEb84Yfl732k9/YVTq+14cK4beJSLhBRVNN4WZTAtXfh2fg6XiC/ix3worL+FufDB bObhoHjI6z1qwvKH4kqHzOlp4GN4NNd5Wq9M4imMqiDExPbw== X-Received: by 2002:a17:907:c207:b0:c11:8357:40f with SMTP id a640c23a62f3a-c11835704bfmr177824666b.2.1782305117916; Wed, 24 Jun 2026 05:45:17 -0700 (PDT) Received: from ?IPV6:2a06:61c2:d427:0:b321:1c7a:b072:326e? ([2a06:61c2:d427:0:b321:1c7a:b072:326e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-697f49d73fdsm1040727a12.22.2026.06.24.05.45.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 05:45:17 -0700 (PDT) Message-ID: <544f2aa1-269d-47a1-b315-5a6fce5637b1@bynar.io> Date: Wed, 24 Jun 2026 13:45:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] tipc: fix out-of-bounds read in broadcast Gap ACK blocks To: Tung Quang Nguyen Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Jon Maloy References: <20260623135443.3662041-1-sam@bynar.io> Content-Language: en-GB From: Sam P In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/06/2026 13:56, Tung Quang Nguyen wrote: > This is wrong because the skb is not dropped as it should be. > Note that 'ga' is NULL just for legacy TIPC that does not support Selective ACK. > To correctly fix this issue, you need to set a flag (for example, a Boolean output parameter) to TRUE instead of 'ga=NULL'. > Then, immediately return and repeatedly pass the flag to tipc_rcv() in order to drop the skb. Thanks for the feedback! I'll address it in a v2.