From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932690AbaJ2LfH (ORCPT ); Wed, 29 Oct 2014 07:35:07 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:60099 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529AbaJ2LfE (ORCPT ); Wed, 29 Oct 2014 07:35:04 -0400 Message-ID: <5450D0E1.7040904@collabora.co.uk> Date: Wed, 29 Oct 2014 12:34:57 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org CC: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Chanwoo Choi Subject: Re: [PATCH v6 2/3] regulator: max77802: Remove suspend_enable References: <1414581294-1315-1-git-send-email-k.kozlowski@samsung.com> <1414581294-1315-3-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1414581294-1315-3-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 10/29/2014 12:14 PM, Krzysztof Kozlowski wrote: > The Maxim 77802 PMIC regulators do not have special enable configuration > for suspend. The driver instead enabled them manually which is not a > best way to deal with suspend. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/regulator/max77802.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c > index 5839c4509e1f..b9958d927297 100644 > --- a/drivers/regulator/max77802.c > +++ b/drivers/regulator/max77802.c After what Mark explained, I understand this is the right thing to do. Acked-by: Javier Martinez Canillas Best regards, Javier