From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2603EBA26; Mon, 8 Jan 2024 08:29:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A28AFC433C7; Mon, 8 Jan 2024 08:29:45 +0000 (UTC) Message-ID: <545138cc-2cc1-4da0-9b26-7ebe4241c8df@xs4all.nl> Date: Mon, 8 Jan 2024 09:29:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag To: Jeffrey Kardatzke Cc: Yunfei Dong , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Nicolas Dufresne , AngeloGioacchino Del Regno , Benjamin Gaignard , Nathan Hebert , Chen-Yu Tsai , Yong Wu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , Sumit Semwal , Brian Starkey , John Stultz , "T . J . Mercier" , =?UTF-8?Q?Christian_K=C3=B6nig?= , Matthias Brugger , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20231206081538.17056-1-yunfei.dong@mediatek.com> <20231206081538.17056-5-yunfei.dong@mediatek.com> Content-Language: en-US, nl From: Hans Verkuil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 04/01/2024 21:05, Jeffrey Kardatzke wrote: > On Mon, Dec 11, 2023 at 3:05 AM Hans Verkuil wrote: >> >> On 06/12/2023 09:15, Yunfei Dong wrote: >>> From: Jeffrey Kardatzke >>> >>> Adds documentation for V4L2_MEMORY_FLAG_SECURE. >>> >>> Signed-off-by: Jeffrey Kardatzke >>> Signed-off-by: Yunfei Dong >>> --- >>> Documentation/userspace-api/media/v4l/buffer.rst | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/userspace-api/media/v4l/buffer.rst b/Documentation/userspace-api/media/v4l/buffer.rst >>> index 52bbee81c080..a5a7d1c72d53 100644 >>> --- a/Documentation/userspace-api/media/v4l/buffer.rst >>> +++ b/Documentation/userspace-api/media/v4l/buffer.rst >>> @@ -696,7 +696,7 @@ enum v4l2_memory >>> >>> .. _memory-flags: >>> >>> -Memory Consistency Flags >>> +Memory Flags >>> ------------------------ >>> >>> .. raw:: latex >>> @@ -728,6 +728,12 @@ Memory Consistency Flags >>> only if the buffer is used for :ref:`memory mapping ` I/O and the >>> queue reports the :ref:`V4L2_BUF_CAP_SUPPORTS_MMAP_CACHE_HINTS >>> ` capability. >>> + * .. _`V4L2-MEMORY-FLAG-SECURE`: >>> + >>> + - ``V4L2_MEMORY_FLAG_SECURE`` >>> + - 0x00000002 >>> + - DMA bufs passed into the queue will be validated to ensure they were >>> + allocated from a secure dma-heap. >> >> Hmm, that needs a bit more work. How about: >> >> - The queued buffers are expected to be in secure memory. If not, an error will be >> returned. This flag can only be used with ``V4L2_MEMORY_DMABUF``. Typically >> secure buffers are allocated using a secure dma-heap. This flag can only be >> specified if the ``V4L2_BUF_CAP_SUPPORTS_SECURE_MEM`` is set. >> > > Thanks Hans. Yunfei, can you integrate this change into the patch please? > >> In addition, the title of this table is currently "Memory Consistency Flags": that >> should be renamed to "Memory Flags". > > Hans, the patch is already renaming the table as you suggested. :) > (unless there's some other spot I'm missing) Sorry for the noise, I missed that change. Regards, Hans >> >> Regards, >> >> Hans >> >>> >>> .. raw:: latex >>> >>