From: Randy Dunlap <rdunlap@infradead.org>
To: Tristan Lelong <tristan@lelong.xyz>,
gregkh@linuxfoundation.org, john.stultz@linaro.org,
rebecca@android.com, ccross@android.com, mitchelh@codeaurora.org,
benjamin.gaignard@linaro.org, romlem@google.com,
daeseok.youn@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: ion: fix typos in comments
Date: Fri, 31 Oct 2014 10:28:30 -0700 [thread overview]
Message-ID: <5453C6BE.30507@infradead.org> (raw)
In-Reply-To: <1414737816-20118-1-git-send-email-tristan@lelong.xyz>
On 10/30/14 23:43, Tristan Lelong wrote:
> Fix some coding style warnings detected by checkpatch.pl in ion.
$Subject is correct but the changelog above is not -- needs to be changed.
>
> Signed-off-by: Tristan Lelong <tristan@lelong.xyz>
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> drivers/staging/android/ion/ion.h | 2 +-
> drivers/staging/android/ion/ion_priv.h | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 290d4d2..8724ef8 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -250,7 +250,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> our systems the only dma_address space is physical addresses.
> Additionally, we can't afford the overhead of invalidating every
> allocation via dma_map_sg. The implicit contract here is that
> - memory comming from the heaps is ready for dma, ie if it has a
> + memory coming from the heaps is ready for dma, ie if it has a
> cached mapping that mapping has been invalidated */
> for_each_sg(buffer->sg_table->sgl, sg, buffer->sg_table->nents, i)
> sg_dma_address(sg) = sg_phys(sg);
> diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
> index d305bb7..443db84 100644
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -76,7 +76,7 @@ struct ion_platform_data {
> * size
> *
> * Calls memblock reserve to set aside memory for heaps that are
> - * located at specific memory addresses or of specfic sizes not
> + * located at specific memory addresses or of specific sizes not
> * managed by the kernel
> */
> void ion_reserve(struct ion_platform_data *data);
> diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
> index c8f0175..18a5f93 100644
> --- a/drivers/staging/android/ion/ion_priv.h
> +++ b/drivers/staging/android/ion/ion_priv.h
> @@ -345,7 +345,7 @@ void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr,
> * functions for creating and destroying a heap pool -- allows you
> * to keep a pool of pre allocated memory to use from your heap. Keeping
> * a pool of memory that is ready for dma, ie any cached mapping have been
> - * invalidated from the cache, provides a significant peformance benefit on
> + * invalidated from the cache, provides a significant performance benefit on
> * many systems */
>
> /**
> @@ -362,7 +362,7 @@ void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr,
> *
> * Allows you to keep a pool of pre allocated pages to use from your heap.
> * Keeping a pool of pages that is ready for dma, ie any cached mapping have
> - * been invalidated from the cache, provides a significant peformance benefit
> + * been invalidated from the cache, provides a significant performance benefit
> * on many systems
> */
> struct ion_page_pool {
>
--
~Randy
prev parent reply other threads:[~2014-10-31 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 6:43 Tristan Lelong
2014-10-31 17:28 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5453C6BE.30507@infradead.org \
--to=rdunlap@infradead.org \
--cc=benjamin.gaignard@linaro.org \
--cc=ccross@android.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
--cc=rebecca@android.com \
--cc=romlem@google.com \
--cc=tristan@lelong.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome