mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Eric Lammerts" <eric@lammerts.org>
To: "Paul Serice" <paul@serice.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iso9660 Inodes Anywhere and NFS
Date: Wed, 9 Jun 2004 01:24:35 -0400 (EDT)	[thread overview]
Message-ID: <54574.67.8.218.172.1086758675.squirrel@webmail.krabbendam.net> (raw)
In-Reply-To: <40BD2841.2050509@serice.net>


"Paul Serice" <paul@serice.net> wrote:
> The inode number scheme was also changed.  Continuing to use the byte
> offset would have resulted in non-unique inodes in many common
> situations, but because the inode number no longer plays any role in
> reading the meta-data off the disk, I was free to set the inode number
> to some unique characteristic of the file.  I have chosen to use the
> block offset which is also 32-bits wide.

But what about 0-byte files? The block offset could be the same for all
0-byte files, or worse, it could be the same as the block offset of a
non-0-byte file.

I don't know if this has been mentioned before, but since a directory
record is always 34 bytes or bigger, why not simply divide the directory
record byte offset by 32? I.e.,

-   inode_number = (bh->b_blocknr << bufbits) + offset;
+   inode_number = (bh->b_blocknr << (bufbits - 5)) + (offset >> 5);

Eric


  parent reply	other threads:[~2004-06-09  5:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-02  1:07 Paul Serice
2004-06-02 11:44 ` Sergey Vlasov
2004-06-02 13:46   ` Paul Serice
2004-06-09  5:24 ` Eric Lammerts [this message]
2004-06-09 10:03   ` Paul Serice
2004-06-09 13:11     ` Eric Lammerts
2004-06-10  3:23       ` Paul Serice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54574.67.8.218.172.1086758675.squirrel@webmail.krabbendam.net \
    --to=eric@lammerts.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@serice.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®