From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6D3C433F5 for ; Wed, 22 Sep 2021 00:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F001061168 for ; Wed, 22 Sep 2021 00:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbhIVA3R convert rfc822-to-8bit (ORCPT ); Tue, 21 Sep 2021 20:29:17 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:15437 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbhIVA3P (ORCPT ); Tue, 21 Sep 2021 20:29:15 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HDfCn4yPszRQFf; Wed, 22 Sep 2021 08:23:33 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 22 Sep 2021 08:27:45 +0800 Received: from dggpeml100016.china.huawei.com (7.185.36.216) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 22 Sep 2021 08:27:44 +0800 Received: from dggpeml100016.china.huawei.com ([7.185.36.216]) by dggpeml100016.china.huawei.com ([7.185.36.216]) with mapi id 15.01.2308.008; Wed, 22 Sep 2021 08:27:44 +0800 From: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" To: Greg KH CC: "andraprs@amazon.com" , "lexnv@amazon.com" , "alcioa@amazon.com" , "linux-kernel@vger.kernel.org" , "Gonglei (Arei)" , "kamal@canonical.com" , "pbonzini@redhat.com" , "sgarzare@redhat.com" , "stefanha@redhat.com" , "vkuznets@redhat.com" , "ne-devel-upstream@amazon.com" Subject: RE: [PATCH v2 1/4] nitro_enclaves: merge contiguous physical memory regions Thread-Topic: [PATCH v2 1/4] nitro_enclaves: merge contiguous physical memory regions Thread-Index: AQHXrvraMNZnMWAuzUKsEPXAU06oZquuFF8AgAEeIgA= Date: Wed, 22 Sep 2021 00:27:44 +0000 Message-ID: <545781e2bac049dea6a46164fce86267@huawei.com> References: <20210921151039.1502-1-longpeng2@huawei.com> <20210921151039.1502-2-longpeng2@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.148.223] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, September 21, 2021 11:21 PM > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > > Cc: andraprs@amazon.com; lexnv@amazon.com; alcioa@amazon.com; > linux-kernel@vger.kernel.org; Gonglei (Arei) ; > kamal@canonical.com; pbonzini@redhat.com; sgarzare@redhat.com; > stefanha@redhat.com; vkuznets@redhat.com; ne-devel-upstream@amazon.com > Subject: Re: [PATCH v2 1/4] nitro_enclaves: merge contiguous physical memory > regions > > On Tue, Sep 21, 2021 at 11:10:36PM +0800, Longpeng(Mike) wrote: > > There can be cases when there are more memory regions that need to be > > set for an enclave than the maximum supported number of memory regions > > per enclave. One example can be when the memory regions are backed by 2 > > MiB hugepages (the minimum supported hugepage size). > > > > Let's merge the adjacent regions if they are physical contiguous. This > > way the final number of memory regions is less than before merging and > > could potentially avoid reaching maximum. > > > > Signed-off-by: Longpeng(Mike) > > --- > > drivers/virt/nitro_enclaves/ne_misc_dev.c | 87 > ++++++++++++++++++++----------- > > 1 file changed, 58 insertions(+), 29 deletions(-) > > > > What changed from v1? It seems you missed the cover letter ?