Re: [PATCH v2 0/6] Add support for USB cluster(PHY muxer) on the Armada 375

[Gregory CLEMENT <gregory.clement@free-electrons.com>]

Hi Jason,

On 01/11/2014 23:46, Jason Cooper wrote:
> Gregory,
> 
> On Fri, Oct 24, 2014 at 05:24:08PM +0200, Gregory CLEMENT wrote:
>> Hello,
>>
>> this is the second version of a series I initially submitted in May:
>> https://lkml.org/lkml/2014/5/16/743
>>
>> This series adds support for the USB cluster which is on the Armada
>> 375 SoC. We can mainly see this device as a PHY muxer.
>>
>> I more or less forgotten this series until the talk of Kishon Vijay
>> Abraham I about the phy framework.
>>
>> Since this time, things have changed in the USB framework and I no
>> longer have to add the generic phy support in the xhci driver since it
>> was done at the usb core level.
>>
>> While I ran coccicheck on my code I also found some possible
>> improvement in the phy driver: it was done in the 1st patch.
>>
>> The second patch was a patch initially submitted by Andrew. This patch
>> added the mvebu-phy.txt but fell through a crack when adding the
>> driver. I join this patch on my series in order to be able to add the
>> new binding for the USB cluster of the Armada 375.
>>
>> This was done in the third patch.
>>
>> The forth patch was the addition of the phys driver itself.
>>
>> The fifth and sixth patches are updating the device tree files related
>> to the Armada 375 using the new biding.
>>
>> Thanks,
>>
>> Gregory
>>
>> Changelog:
>>
>> v1 -> v2:
>>
>> - Add a patch fixing the use of PTR_ERR_OR_ZERO.
>>
>> - Add the patch adding the DT binding documentation for Marvell MVEBU
>> SATA phy from Andrew Lunn
>>
>> - Move the DT binding documentation of the Armada 375 USB cluster into
>>   the phy-mvebu.txt file.
>>
>> - Made the armada375_usb_phy_xlate more robust" if there is a phy_put
>>   and then a phy_get".
>>
>> Andrew Lunn (1):
>>   Phy: DT binding documentation for Marvell MVEBU SATA phy.
>>
>> Gregory CLEMENT (5):
>>   phy: Use PTR_ERR_OR_ZERO to fix warning raised by coccinelle
>>   Phy: DT binding documentation for the Armada 375 USB cluster binding
>>   phy: add support for USB cluster on the Armada 375 SoC
>>   ARM: mvebu: add Device Tree description of USB cluster controller on
>>     Armada 375
>>   ARM: mvebu: add PHY support to the dts for the USB controllers on
>>     Armada 375
> 
> I assume Kishon is taking the phy portion of this series and we'll
> handle the dts portion? 

Yes I expect that we merge the patch 5 and 6, and patch 1-4 should
be pulled by Kishon.


> Before doing so, I'd like to see an Ack from
> the DT maintainers and Kishon...

I also would like have a feedback from them :)


Thanks,

Gregory

> 
> thx,
> 
> Jason.
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com