From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbcF1Mtk (ORCPT ); Tue, 28 Jun 2016 08:49:40 -0400 Received: from outbound.smtp.vt.edu ([198.82.183.121]:39102 "EHLO omr1.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752077AbcF1Mti (ORCPT ); Tue, 28 Jun 2016 08:49:38 -0400 X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6+dev To: Alexander Kapshuk Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH 32/32] ver_linux: 'printversion()' function definition From: Valdis.Kletnieks@vt.edu In-Reply-To: <1467109146-20331-32-git-send-email-alexander.kapshuk@gmail.com> References: <1467109146-20331-1-git-send-email-alexander.kapshuk@gmail.com> <1467109146-20331-32-git-send-email-alexander.kapshuk@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1467118075_2085P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 28 Jun 2016 08:47:55 -0400 Message-ID: <54584.1467118075@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1467118075_2085P Content-Type: text/plain; charset=us-ascii On Tue, 28 Jun 2016 13:19:06 +0300, Alexander Kapshuk said: > Definition of the 'printversion()' function. The function tests whether > the variable that contains the version number is empty, and prints > the name of the utility and its version number as a formatted string, > if the version number is not an empty value. This needs to be the first patch in the series, not the last, so that if you're applying the patches one by one, the result still works, which allows incremental testing after each patch. Putting it last means you have to apply all 32 patches before you get something you can test. The idea is good, however. One thing that might be good now that it's only one chunk of code, is to add some code to check between the following cases: it's something like isdnctrl or cardmgr that's not installed because it's truly optional in today's world where ISDN or PCMCIA slots have become rare, or if the regexp doing the matching failed because the utility is present but produced unexpected output. Another useful thing would be distinguishing between must-have things like the toolchain where the build *will* fail, and optionals that are only used in some configurations. This will probably require reordering the output (and corresponding changes to Documentation/Changes) --==_Exmh_1467118075_2085P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Exmh version 2.5 07/13/2001 iQIVAwUBV3Jx+wdmEQWDXROgAQKHKw/+NIsPZ8t3jJEIrsQMHZwW65q+MQans9VC 23atLLdjEcquvPLu0uQe1WTeR6MQ5mvoHiKS2jaOoamR6UV5NrMYKjW2A8Mp61El keyd/NC57DelvlSozF2xdrV9uLv43x8nJ6FcMni9O1FhPAf2Ykng8SIyBCLBLtIS noOqmR1kfpwYbB3WerubGN3qM2xBIB0EL3YpT0Z3QRk7P3xgWeRCWSe7njgMSrCp PD6dnBQeTwiO0mbtEEi4+J5r1CdIba/7vp2EmNvB9I3W+DnhQB9ECa7762N5M8Lv Dy2wbDnDrPn7JPh2aerKF5jlK4etTbYEPX1goaCCelnbjDwmfp00JwG+81+QNIns W6WAFLBY7br+gsDj6UlyH/iRpimaPj9jfYkj0s3xP9+3AyTNFjoem4n+qt0UNDrO FjkNgYFJl3me6swlemC7/GGnsZadhmYOyACp7L2odt6N9M5Dk9ZWG6IiQKJeYr/o YnR6H3hTVVSL7yc5/nHIZ/wVBtAJ7Qn3y8pRPDppNyul0WE+Z8VV5R/oCKrjYmMF TmAxuQ3EN/SuKrhT3IRYdhrQ8aiXqf24N2zCjw6NGteeUdRwxlqLmMiIqxbp3ggA EKtmyoQcMw+BJaCl6ZbqNmyLn6LFJoGoLyzcpxmsE/KqnCdPuzB7KoOeWhHKMOXy 7Mdy55ebMuM= =2cGs -----END PGP SIGNATURE----- --==_Exmh_1467118075_2085P--