From: Boaz Harrosh <boaz@plexistor.com>
To: Boaz Harrosh <boaz@plexistor.com>, Jens Axboe <axboe@fb.com>,
Matthew Wilcox <willy@linux.intel.com>,
Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 5/5 v4] brd: Add getgeo to block ops for fdisk
Date: Wed, 05 Nov 2014 17:18:16 +0200 [thread overview]
Message-ID: <545A3FB8.5080004@plexistor.com> (raw)
In-Reply-To: <545A3EC8.3060203@plexistor.com>
On 11/05/2014 05:14 PM, Boaz Harrosh wrote:
> From: Boaz Harrosh <boaz@plexistor.com>
>
Sorry
[V4]
Also fix the cryptic comment at the source code.
I have pushed new trees to the public tree as well
Thanks
Boaz
<>
> +static int brd_getgeo(struct block_device *bd, struct hd_geometry *geo)
> +{
> + /* With the usual emulated values of 64, 32, X and the
> + * default size of 4M device, fdisk will offer 40 as possible
> + * first-sector.
> + * But with the values presented here of 1, 1, 1 fdisk will
> + * offer 8 (4K) as possible first sector.
> + * Otherwise, either way, it effects nothing. Only fdisk calls
> + * this vector at all.
> + */
> + geo->heads = 1;
> + geo->sectors = 1;
> + geo->cylinders = 1;
> + return 0;
> +}
> +
> static const struct block_device_operations brd_fops = {
> .owner = THIS_MODULE,
> .rw_page = brd_rw_page,
> @@ -433,6 +450,7 @@ static const struct block_device_operations brd_fops = {
> #ifdef CONFIG_BLK_DEV_XIP
> .direct_access = brd_direct_access,
> #endif
> + .getgeo = brd_getgeo,
> };
>
> /*
>
next prev parent reply other threads:[~2014-11-05 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 14:00 [PATCHSET 0/5 v3] brd: partition fixes Boaz Harrosh
2014-11-05 14:01 ` [PATCH 1/5] axonram: Fix bug in direct_access Boaz Harrosh
2014-11-05 14:02 ` [PATCH 2/5] block: Change direct_access calling convention Boaz Harrosh
2014-11-05 14:04 ` [PATCH 3/5] brd: Fix all partitions BUGs Boaz Harrosh
2014-11-05 14:08 ` [PATCH 4/5] brd: Request from fdisk 4k alignment Boaz Harrosh
2014-11-05 14:20 ` Martin K. Petersen
2014-11-05 14:43 ` Boaz Harrosh
2014-11-06 17:25 ` Martin K. Petersen
2014-11-07 9:10 ` Karel Zak
2014-11-09 17:52 ` Boaz Harrosh
2014-11-10 17:00 ` Martin K. Petersen
2014-11-05 14:10 ` [PATCH 5/5] brd: Add getgeo to block ops for fdisk Boaz Harrosh
2014-11-05 15:14 ` [PATCH 5/5 v4] " Boaz Harrosh
2014-11-05 15:18 ` Boaz Harrosh [this message]
2014-11-07 9:23 ` [PATCH 5/5] " Karel Zak
2014-11-09 16:57 ` Boaz Harrosh
2014-11-10 9:58 ` Karel Zak
2014-11-10 11:15 ` Boaz Harrosh
2014-11-10 13:26 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A3FB8.5080004@plexistor.com \
--to=boaz@plexistor.com \
--cc=axboe@fb.com \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome