mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Barto <mister.freeman@laposte.net>
To: Tejun Heo <tj@kernel.org>
Cc: bhelgaas@google.com, aaron.lu@intel.com, rjw@rjwysocki.net,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	chuansheng.liu@intel.com
Subject: Re: [PATCH] PCI: Do not enable async suspend for JMicron chips
Date: Wed, 05 Nov 2014 18:58:31 +0100	[thread overview]
Message-ID: <545A6547.1030709@laposte.net> (raw)
In-Reply-To: <20141105163159.GE14386@htj.dyndns.org>

I tried the patch, it solves the problem,

but I had to change the patch in order to be compatible with 3.18rc3
source code :

patching file drivers/pci/pci.c
Hunk #1 FAILED at 2046.
1 out of 1 hunk FAILED -- saving rejects to file drivers/pci/pci.c.rej

here is the correct patch for kernel 3.18rc3 source code :

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2046,7 +2046,17 @@ void pci_pm_init(struct pci_dev *dev)
 	pm_runtime_forbid(&dev->dev);
 	pm_runtime_set_active(&dev->dev);
 	pm_runtime_enable(&dev->dev);
-	device_enable_async_suspend(&dev->dev);
+	
+     /*
+      * The JMicron chip 361/363/368 contains one SATA controller and
+      * one PATA controller, they are brother-relation ship in PCI tree,
+      * but for powering on these both controller, we must follow the
+      * sequence one by one, otherwise one of them can not be powered on
+      * successfully, so here we disable the async suspend method for
+      * Jmicron chip.
+      */
+     if (dev->vendor != PCI_VENDOR_ID_JMICRON)
+         device_enable_async_suspend(&dev->dev);
 	dev->wakeup_prepared = false;

 	dev->pm_cap = 0;


Le 05/11/2014 17:31, Tejun Heo a écrit :
> On Wed, Nov 05, 2014 at 09:07:45AM +0800, Chuansheng Liu wrote:
>> The JMicron chip 361/363/368 contains one SATA controller and
>> one PATA controller, they are brother-relation ship in PCI tree,
>> but for powering on these both controller, we must follow the
>> sequence one by one, otherwise one of them can not be powered on
>> successfully.
>>
>> So here we disable the async suspend method for Jmicron chip.
>>
>> Cc: stable@vger.kernel.org # 3.15+
>> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> 
> Applied to libata/for-3.18-fixes.
> 
> Thanks.
> 

  reply	other threads:[~2014-11-05 17:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05  1:07 Chuansheng Liu
2014-11-05  1:33 ` Aaron Lu
2014-11-05  1:35   ` Aaron Lu
2014-11-05 16:31 ` Tejun Heo
2014-11-05 17:58   ` Barto [this message]
2014-11-05 18:04   ` Tejun Heo
2014-11-05  1:31 Chuansheng Liu
2014-11-05 18:01 ` Bjorn Helgaas
2014-11-05 18:46   ` Barto
2014-11-05 19:03     ` Bjorn Helgaas
2014-11-06  1:36       ` Barto
2014-11-06  1:48       ` Liu, Chuansheng
2014-11-06  4:08         ` Bjorn Helgaas
2014-11-06  5:29           ` Barto
2014-11-06  5:29           ` Liu, Chuansheng
2014-11-06  5:36             ` Aaron Lu
2014-11-06  6:39               ` Liu, Chuansheng
2014-11-06  8:25                 ` Barto
2014-11-06 17:39                 ` Bjorn Helgaas
2014-11-06 21:02                   ` Barto
2014-11-07  1:09                   ` Liu, Chuansheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545A6547.1030709@laposte.net \
    --to=mister.freeman@laposte.net \
    --cc=aaron.lu@intel.com \
    --cc=bhelgaas@google.com \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome