From: Stephen Warren <swarren@nvidia.com>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: pdeschrijver@nvidia.com, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] clocksource: tegra: Port tegra20 clocksource to arm64
Date: Thu, 06 Nov 2014 21:17:00 -0700 [thread overview]
Message-ID: <545C47BC.4050207@nvidia.com> (raw)
In-Reply-To: <1415319715-21757-1-git-send-email-anatol.pomozov@gmail.com>
On 11/06/2014 05:21 PM, Anatol Pomozov wrote:
> register_persistent_clock() are in different headers in arm/arm64
>
> Tested: Compiled the driver on 64bit platform and make sure that
> it works
I assume "it works" refers to "it compiles" not "it executes successfully"?
I think it'd be better to make the same APIs available on arm and arm64,
or even across all architectures.
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
> ---
> drivers/clocksource/tegra20_timer.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
> index d2616ef..e0123c7 100644
> --- a/drivers/clocksource/tegra20_timer.c
> +++ b/drivers/clocksource/tegra20_timer.c
> @@ -29,8 +29,12 @@
> #include <linux/sched_clock.h>
> #include <linux/delay.h>
>
> +#ifdef CONFIG_ARM64
> +#include <asm/time.h>
> +#else
> #include <asm/mach/time.h>
> #include <asm/smp_twd.h>
> +#endif
>
> #define RTC_SECONDS 0x08
> #define RTC_SHADOW_SECONDS 0x0c
>
next prev parent reply other threads:[~2014-11-07 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 0:21 Anatol Pomozov
2014-11-07 4:17 ` Stephen Warren [this message]
2014-11-07 4:26 ` Anatol Pomozov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C47BC.4050207@nvidia.com \
--to=swarren@nvidia.com \
--cc=anatol.pomozov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pdeschrijver@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®