From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>,
David Vrabel <david.vrabel@citrix.com>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xensource.com>,
<konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
<x86@kernel.org>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH V2 2/5] xen: Delay m2p_override initialization
Date: Fri, 7 Nov 2014 14:08:46 +0000 [thread overview]
Message-ID: <545CD26E.8040404@citrix.com> (raw)
In-Reply-To: <545CC6D8.80100@suse.com>
On 07/11/14 13:19, Juergen Gross wrote:
> On 11/07/2014 02:04 PM, David Vrabel wrote:
>>
>> I suppose this is the "make some functions static" but it's an
>> unreviewable mess. If you can't do this with some one line changes
>> adding "static" and perhaps some forward declarations then please drop
>> this bit.
>
> Do you really prefer forward declarations instead of pure code movement?
> I can do as you request, but just want to make sure.
Normally I prefer not having forward declarations... How about a patch
that does this and then a 2nd patch that does the pure code motion.
Maybe that will produce a better diff?
You can also try the --patience option for git diff (etc.). This may
produce more readable diffs.
David
next prev parent reply other threads:[~2014-11-07 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 5:47 [PATCH V2 0/5] xen: Switch to virtual mapped linear p2m list Juergen Gross
2014-11-06 5:47 ` [PATCH V2 1/5] Xen: Delay remapping memory of pv-domain Juergen Gross
2014-11-07 14:57 ` [Xen-devel] " David Vrabel
2014-11-06 5:47 ` [PATCH V2 2/5] xen: Delay m2p_override initialization Juergen Gross
2014-11-07 13:04 ` [Xen-devel] " David Vrabel
2014-11-07 13:19 ` Juergen Gross
2014-11-07 14:08 ` David Vrabel [this message]
2014-11-06 5:47 ` [PATCH V2 3/5] xen: Delay invalidating extra memory Juergen Gross
2014-11-07 13:57 ` David Vrabel
2014-11-06 5:47 ` [PATCH V2 4/5] x86: Introduce function to get pmd entry pointer Juergen Gross
2014-11-06 5:47 ` [PATCH V2 5/5] Xen: switch to linear virtual mapped sparse p2m list Juergen Gross
2014-11-07 13:54 ` [Xen-devel] " David Vrabel
2014-11-07 14:11 ` Juergen Gross
2014-11-07 14:40 ` David Vrabel
2014-11-07 14:43 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CD26E.8040404@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®