Re: [PATCH] tools/testing/vma: Fix function parameter declarations for GCC 8.3 compatibility

[Vlastimil Babka <vbabka@suse.cz>]

On 8/1/25 11:33, Lorenzo Stoakes wrote:
> On Fri, Aug 01, 2025 at 05:26:50PM +0800, WangYuli wrote:
>> Hi Lorenzo,
>>
>> Should I split this into two commits?
>>
>> As Vlastimil Babka suggested, perhaps it would be better to add both the
>> |-std=gnu11| and |-Wno-unused-parameter| flags to
>> |tools/testing/shared/shared.mk|.

I did suggest -std=gnu11, but -Wno-unused-parameter shouldn't be necessary
as there's nothing enabling the warning that we need to override.

> Sure, perhaps 2 patches is best, 1 for changes to shared.mk and 1 for the
> fixups to vma_internal.h.

You could even do 3 patches - separate your original addition of parameters
from the removal of "(void)foo;". Somebody might care enough to backport the
compilation fix alone to older versions.
> Also note Vlasta's reply here, he suggested some other stuff.
> 
> Thanks very much for doing this, you're saving me some work by fixing up
> the silly (void) stuff and I appreciate you fixing this for older gcc! :>)
> 
> I will make sure to review this once submitted.
> 
> Cheers, Lorenzo