From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F448C10DCE for ; Thu, 7 Dec 2023 19:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbjLGTQX (ORCPT ); Thu, 7 Dec 2023 14:16:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjLGTQV (ORCPT ); Thu, 7 Dec 2023 14:16:21 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C61910DC for ; Thu, 7 Dec 2023 11:16:27 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-50bf82f4409so1120723e87.0 for ; Thu, 07 Dec 2023 11:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701976586; x=1702581386; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9Njx3DTvexbkSox5QqyKZyNLg2RSJfBg1X63hFLY1KM=; b=RFX5feVUGwwvw6KncI/OM6otptG18NUUXkWhNnzK6QIG44A9waHYmUTtutgoqeS1qD S2hREuw0HtX7v+sRc10pi9U7rbmxKdQ8NeWlV6sWgy1Ba+Z712nHorjj9VOrvOvLtpka HLVslUo3UHgFRIFvPn+Qdg6AWGBsvdqVbNf2msLP1yKFcqMdU7BEKIsus5c1UWUx3kDj uib01GYELW951rLfukQ6P1fry6rvq4fpYooa7gk/C7/JjYYt8fStyK8QgNMcCwQqPYXn DlJwYjeS74QcXZeRG8htoXWjXIvfcekYwcodpYebt2CxWUFlLrd+P6yOLex+w/GtbKoh dI/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701976586; x=1702581386; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Njx3DTvexbkSox5QqyKZyNLg2RSJfBg1X63hFLY1KM=; b=g9qdjos5eEeJC39KEOQBE/pp75WCzqMYeAoQRv9p5iEp+q5p3Z77Z9+tMJBIdCrb1k wlz5g6ARt6l4bY5hdGVCsuFYxwWZc1T/kHbON9de2QpPgofXIO7I/5VytIfeq967r2MW 2istNX+Q0BZueYUslY6zCiv3PFbUhWhKjEAn31TwlYKQXDy18fa7JpZ1DIU+wJRdnVWJ O2OLu0i5I/toLJ0DmzAYJXf2ipmefXawABdwQii9KUX+su6nSxkE3LdHr4B9S465hfqk /JSoOlIc73D/B+tJvfbKWwLcgMIe/D/g+TQkPmD8hTBvPGGth0EuPBMQkzB9eHBVDMrJ P/eg== X-Gm-Message-State: AOJu0Yzcxw1ODpmAgY8yXS4UgBNJ/9LD3qYxmvQXnfhCx8A/xmxX8oa1 JU6sOgDVCj/AhqJKMHh5E4tNjQ== X-Google-Smtp-Source: AGHT+IGaN3FmyZNrLbkDLl2aF5fW0Mr4v/txXTd2hd8fE41nJB/ar2K2hjxM7QHkmGusyTiDEXZ88g== X-Received: by 2002:a05:6512:4d0:b0:50b:fa6e:e386 with SMTP id w16-20020a05651204d000b0050bfa6ee386mr3129058lfq.30.1701976585818; Thu, 07 Dec 2023 11:16:25 -0800 (PST) Received: from [172.30.205.181] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id f20-20020a193814000000b0050c219545efsm23109lfa.200.2023.12.07.11.16.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Dec 2023 11:16:25 -0800 (PST) Message-ID: <545d3ace-66e5-4470-b3a4-cbdac5ae473d@linaro.org> Date: Thu, 7 Dec 2023 20:16:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] dt-bindings: phy: qcom-edp: Add X1E80100 PHY compatibles Content-Language: en-US To: Krzysztof Kozlowski , Abel Vesa , Andy Gross , Bjorn Andersson , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abhinav Kumar , Dmitry Baryshkov , Johan Hovold Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231122-phy-qualcomm-edp-x1e80100-v3-0-576fc4e9559d@linaro.org> <20231122-phy-qualcomm-edp-x1e80100-v3-2-576fc4e9559d@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/23 17:51, Krzysztof Kozlowski wrote: [...] >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,x1e80100-dp-phy >> + then: >> + properties: >> + phy-type: >> + description: DP (default) or eDP type > > Properties must be defined in top-level "properties:" block. In > allOf:if:then you only disallow them for other variants. > >> + enum: [ 6, 13 ] >> + default: 6 > > Anyway, I was thinking this should be rather argument to phy-cells. I'm not sure I'm for this, because the results would be: --- device.dts --- &dp_controller0 { phys = <&dp_phy0 PHY_EDP>; }; &dp_controller1 { phys = <&dp_phy1 PHY_DP>; }; ------------------ as opposed to: --- device.dts --- &dp_phy0 { phy-type ; }; &dp_phy1 { phy-type = ; }; ------------------ i.e., we would be saying "this board is connected to this phy instead" vs "this phy is of this type on this board". While none of them really fit the "same hw, different config" situation, I'd vote for the latter one being closer to the truth Konrad