Re: [PATCH] perf, amd, ibs: Update IBS MSRs and feature definitions

[Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>]

On 11/8/2014 3:03 AM, Borislav Petkov wrote:
> On Thu, Nov 06, 2014 at 10:57:40AM -0600, Aravind Gopalakrishnan wrote:
>> On 11/6/2014 10:34 AM, Borislav Petkov wrote:
>>> On Thu, Nov 06, 2014 at 10:26:22AM -0600, Aravind Gopalakrishnan wrote:
>>>> diff --git a/arch/x86/include/uapi/asm/msr-index.h b/arch/x86/include/uapi/asm/msr-index.h
>>>> index e21331c..ba7b609 100644
>>>> --- a/arch/x86/include/uapi/asm/msr-index.h
>>>> +++ b/arch/x86/include/uapi/asm/msr-index.h
>>>> @@ -206,6 +206,8 @@
>>>>   #define MSR_AMD64_IBSOP_REG_MASK	((1UL<<MSR_AMD64_IBSOP_REG_COUNT)-1)
>>>>   #define MSR_AMD64_IBSCTL		0xc001103a
>>>>   #define MSR_AMD64_IBSBRTARGET		0xc001103b
>>>> +#define MSR_AMD64_IBS_FETCH_EXTD_CTL	0xc001103c
>>>> +#define MSR_AMD64_IBSOPDATA4		0xc001103d
>>>>   #define MSR_AMD64_IBS_REG_COUNT_MAX	8 /* includes MSR_AMD64_IBSBRTARGET */
>>>>   /* Fam 16h MSRs */
>> But Why?
>> IBS_CAPS_BRNTRGT and IBS_CAPS_OPDATA4 indicate support for the respective
>> MSRs
> Ok, I was just making sure.
>
> Btw, MSR_AMD64_IBS_FETCH_EXTD_CTL seems unused. Forgotten?
>

No, There aren't any bits in MSR_AMD64_IBS_FETCH_EXTD_CTL that we need 
to configure right now.
So, have included it here mainly to keep the MSR listing consistent with 
the manual.

Thanks,
-Aravind.