mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-arm-kernel@lists.infradead.org,
	will.deacon@arm.com, marc.zyngier@arm.com, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh@kernel.org, frowand.list@gmail.com,
	mathieu.poirier@linaro.org, peterz@infradead.org,
	Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH v4 3/6] coresight: of: Use of_cpu_node_to_id helper
Date: Tue, 8 Aug 2017 10:41:35 +0100	[thread overview]
Message-ID: <5460b978-e624-6b38-fe3d-6427eed3ebd7@arm.com> (raw)
In-Reply-To: <201708081748.bujrMOmJ%fengguang.wu@intel.com>

On 08/08/17 10:18, kbuild test robot wrote:
> Hi Suzuki,
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.13-rc4 next-20170807]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Suzuki-K-Poulose/perf-Support-for-ARM-DynamIQ-Shared-Unit-PMU/20170808-124822
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm
>
> Note: the linux-review/Suzuki-K-Poulose/perf-Support-for-ARM-DynamIQ-Shared-Unit-PMU/20170808-124822 HEAD 5757d34d451ed5a1452526b27b0f36664a8f2007 builds fine.
>       It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
>    drivers//hwtracing/coresight/of_coresight.c: In function 'of_coresight_get_cpu':
>>> drivers//hwtracing/coresight/of_coresight.c:117:19: error: expected ';' before numeric constant
>      return (cpu < 0) 0 : cpu;
>                       ^
>
> vim +117 drivers//hwtracing/coresight/of_coresight.c
>
>    103	
>    104	int of_coresight_get_cpu(const struct device_node *node)
>    105	{
>    106		int cpu;
>    107		struct device_node *dn;
>    108	
>    109		dn = of_parse_phandle(node, "cpu", 0);
>    110		/* Affinity defaults to CPU0 */
>    111		if (!dn)
>    112			return 0;
>    113		cpu = of_cpu_node_to_id(dn);
>    114		of_node_put(dn);
>    115	
>    116		/* Affinity to CPU0 if no cpu nodes are found */
>  > 117		return (cpu < 0) 0 : cpu;
>    118	}
>    119	EXPORT_SYMBOL_GPL(of_coresight_get_cpu);
>    120	
>

Thanks for the bug report, I will respin the series with a fix for this.

Suzuki

  reply	other threads:[~2017-08-08  9:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07  9:52 [PATCH v4 0/6] perf: Support for ARM DynamIQ Shared Unit PMU Suzuki K Poulose
2017-08-07  9:52 ` [PATCH v4 1/6] perf: Export perf_event_update_userpage Suzuki K Poulose
2017-08-07  9:52 ` [PATCH v4 2/6] of: Add helper for mapping device node to logical CPU number Suzuki K Poulose
2017-08-07 23:33   ` Rob Herring
2017-08-07  9:52 ` [PATCH v4 3/6] coresight: of: Use of_cpu_node_to_id helper Suzuki K Poulose
2017-08-08  9:18   ` kbuild test robot
2017-08-08  9:41     ` Suzuki K Poulose [this message]
2017-08-07  9:52 ` [PATCH v4 4/6] irqchip: gic-v3: " Suzuki K Poulose
2017-08-07  9:52 ` [PATCH v4 5/6] dt-bindings: Document devicetree binding for ARM DSU PMU Suzuki K Poulose
2017-08-07  9:52 ` [PATCH v4 6/6] perf: ARM DynamIQ Shared Unit PMU support Suzuki K Poulose
2017-08-08 10:57   ` kbuild test robot
2017-08-08 10:58     ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5460b978-e624-6b38-fe3d-6427eed3ebd7@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®