From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500AbbJPOTw (ORCPT ); Fri, 16 Oct 2015 10:19:52 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57575 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbbJPOTt (ORCPT ); Fri, 16 Oct 2015 10:19:49 -0400 From: Arnd Bergmann To: James Bottomley Cc: linux-scsi@vger.kernel.org, Hannes Reinecke , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support Date: Fri, 16 Oct 2015 16:19:18 +0200 Message-ID: <5461074.f3cLgYkzKJ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445003624.2191.2.camel@HansenPartnership.com> References: <4351271.eUtUWpTn54@wuerfel> <1445003624.2191.2.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:2KlCZwws4ytCWbCUMK8KdMwS7WD9kRu/nQFcG2jCA2SpbuyjFIm p1OtDwPsUH41XcAJ/jVdCttiBF5tGl36BukjMF/lacN5JTMA5tsmlklYuHPsS3S+kAqVCOg 0fmWhBBx/1hEljqMlCiC5QAOpE8HMthKTmgaJP5MHAfFKhUiHxXu572mheiyXWoev84IcSq 52NFhxGqjl6Tq1TEgpfMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:OqpO+zEJaA4=:IuMKPePHjNJNcK1R9u2jIj NqFEWIPw+fNqA35d8YPv78ciPoJdnRVCHAm2jXKdPhDNuZx3237Y8IRX95ur+UiPvREAiHbtI M4sjS69duBoUbzjbPuohCZAoSQyZ7VQVNtaCPwnGNlqQpnca0ze4I4fmcdcVjtmTFk3UWO1Oz JoOOUz1dGM+6BbCqcoOfF3jM9epIB8FZmTFCxf9oG9L4V57+Zm/R0BfuDOze9TKoQMh8Ltf/p G6/5ABy0uJoZvqNYMPDRCL3FC05iI47NpmpCHos625ZUCUKPofiUe8uCYX7m5mtFjo9mKqOir LvU4KmJIWMDkU+WItAys2vrqYCG6WxpjsM1mmiU7Bvtg3vaW3S6ruK9sZSdRu6iAZ2xd7zJA9 Tfr/ECMyRkHxOywdb43APVW4tc3bGwwHxbGxyT2fEyBxI1oD+EfYZZo5SVPxU6fkL+PM8Zz62 4PR824XO/qfK822yTOeISbrKl8kOJk0yFek72ygJh8NWJHYZss3cHeHVCDBPbb8ln/NR/tuq5 dpzQ1P4lneYZSvMiIxSHqhEu97p/G8mMCw2rthB0SHwB9XsYDysEuTCo21e/6C8mLvHIvmX4N eDSn9JdumSYSKfHA7BIsSPobPQevPlvUsX2vxPwO1PWrQu5ikepVDfy1E8OOEvMwM+GvRJ0O9 kb4Rm75FlXWc+VbTvNZcqXOYJkCFKeunbNJkqkGMWRxwzKXbNepb5y27vh2z8KuTkvnysFr2n 1ATLal5ie0vF7T1D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 16 October 2015 06:53:44 James Bottomley wrote: > > > > Signed-off-by: Arnd Bergmann > > > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > > index d2f480b04a52..1d8b8257773d 100644 > > --- a/drivers/scsi/Kconfig > > +++ b/drivers/scsi/Kconfig > > @@ -498,7 +498,7 @@ config SCSI_DPT_I2O > > config SCSI_ADVANSYS > > tristate "AdvanSys SCSI support" > > depends on SCSI > > - depends on ISA || EISA || PCI > > + depends on (ISA && ISA_DMA_API) || EISA || PCI > > I thought the desire was to avoid a compile failure when ISA && ! > ISA_DMA_API? Won't this one fail if ISA is defined with either EISA or > PCI and !ISA_DMA_API? I thought I had it ruled out, but now I've actually found a combination: we can build an ARM kernel that supports two ancient machines, and one of them supports ISA (but not ISA_DMA_API), while the other one supports PCI. I had looked through several thousand randconfig builds and not found this combination together with advansys, but I guess that is because those were mostly old builds from the times when there was a dependency on VIRT_TO_BUS that this platform doesn't have. So screw this one and go back to the original patch. Arnd