From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934881AbaKNCXO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Nov 2014 21:23:14 -0500
Received: from mail-pd0-f175.google.com ([209.85.192.175]:62038 "EHLO
	mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933888AbaKNCXM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Nov 2014 21:23:12 -0500
Message-ID: <5465678E.3070604@gmail.com>
Date: Fri, 14 Nov 2014 10:23:10 +0800
From: Charles Chiou <ch1102chiou@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
CC: JBottomley@parallels.com, linux-pm@vger.kernel.org
Subject: Re: [V2 PATCH 3/4] scsi:stex.c Add reboot support
References: <5462D62C.50602@gmail.com> <20141112172750.GB18862@infradead.org> <546482FC.2090207@gmail.com>
In-Reply-To: <546482FC.2090207@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 11/13/2014 06:07 PM, Charles Chiou wrote:
>
>
> On 11/13/2014 01:27 AM, Christoph Hellwig wrote:
>>> +static int stex_reboot_callback(struct notifier_block *self,
>>> +                              unsigned long val,
>>> +                              void *data)
>>> +{
>>> +    if (val == SYS_RESTART)
>>> +        isRestart = 1;
>>> +    return NOTIFY_OK;
>>> +}
>>>
>>> @@ -1832,7 +1859,14 @@ static void stex_shutdown(struct pci_dev *pdev)
>>>   {
>>>       struct st_hba *hba = pci_get_drvdata(pdev);
>>>
>>> -    stex_hba_stop(hba);
>>> +    if (hba->yellowstone == 1)
>>> +        stex_hba_stop(hba, ST_IGNORED);
>>> +    else {
>>> +        if (isRestart)
>>> +            stex_hba_stop(hba, ST_S6);
>>> +        else
>>> +            stex_hba_stop(hba, ST_S5);
>>> +    }
>>
>> This sort of check for reboot vs restart isn't really something
>> we want in drivers.  I don't really know how we could find this
>> out assuming we even want drivers to behave differently.
>>
>> Maybe Greg or someone on lkml has an idea how to best handle this case.


Hi, we don't attempt to check for restart vs reboot,
sorry for confusing. When host is going to restart/reboot, Pegasus need 
to restart too. Pegasus use same flow for restart and reboot.

Maybe I could change variable name "isRestart" to "isReboot"?