Re: [PATCH] drm/panel: kingdisplay-kd097d04: Disable EoTp

[Christoph Fritz <chf.fritz@googlemail.com>]

>  >> Fixes: d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp 
> by default")

Nitpick: Your Mailclient messed up quoting.

>  >
>  > Just to clarify: This is not a fix for that commit, it is a fix for the
>  > panel driver itself.
>  >
>  > EoTp is the default in Linux, a panel driver cannot enable it, only
>  > disable it.
>  >
>  > Commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
>  > default") fixed a bug in the synopsys dw-mipi-dsi because EoTp was not
>  > enabled there by default.
>  >
>  > Enabling EoTp in dw-mipi-dsi revealed an underlying issue in panel-
>  > kingdisplay-kd097d04.
>  >
>  > That same issue appears if one would connect this panel to a different
>  > mipi-dsi core (because there EoTp is also enabled by default).
>  >
> thanks for your clarification. You're right, this change is merely a 
> workaround for the kingdisplay panel.

It's not a workaround, it's the actual fix.

> However, I'm in favor of keeping the "Fixes:" line since using bisect, 
> commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
> default") is found as the first commit that shows distorted output for 
> that panel.

Documentation states:

 || A Fixes: tag indicates that the patch fixes a bug in a previous
 || commit

You are quoting the wrong commit in your Fixes: tag.