From: Mikko Perttunen <mikko.perttunen@kapsi.fi>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>,
Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Vincenzo Frascino <vincenzo.frascino@st.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Lukasz Majewski <l.majewski@majess.pl>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver
Date: Mon, 17 Nov 2014 14:51:24 +0200 [thread overview]
Message-ID: <5469EF4C.1050007@kapsi.fi> (raw)
In-Reply-To: <20141117114341.GF25699@ulmo>
On 11/17/2014 01:43 PM, Thierry Reding wrote:
> On Fri, Nov 14, 2014 at 12:47:33PM +0200, Mikko Perttunen wrote:
>> Tested-by: Mikko Perttunen <mikko.perttunen@kapsi.fi>
>>
>> One potential issue I can see is that if the cpufreq driver fails to probe
>> then you'll never get the thermal driver either. For example, Tegra124
>> currently has no cpufreq driver, so if CONFIG_CPU_THERMAL was enabled, then
>> the soctherm driver would never be able to probe. But I don't really have a
>> solution for this either.
>
> It doesn't seem like there's any code whatsoever to deal with cpufreq
> within the soctherm driver, so deferring probe based on something we're
> not using anyway seems rather useless.
>
> Thierry
>
My understanding is that there needs to be no code inside soctherm to
handle it, as the cpufreq driver (cpufreq-dt) will register a cooling
device that will then be bound to the soctherm sensors using the
of-thermal device tree properties. At this moment, however, we don't
have that cpufreq driver so this patch is still useless for Tegra.
Mikko
next prev parent reply other threads:[~2014-11-17 12:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 8:27 [PATCH 0/3] thermal: fix: Various fixes for thermal subsystem Lukasz Majewski
2014-09-24 8:27 ` [PATCH 1/3] thermal: step_wise: fix: Prevent from binary overflow when trend is dropping Lukasz Majewski
2014-10-02 21:13 ` Eduardo Valentin
2014-10-03 7:26 ` Lukasz Majewski
2014-10-09 3:14 ` Zhang Rui
2014-09-24 8:27 ` [PATCH 2/3] thermal: core: fix: Initialize the max_state variable to 0 Lukasz Majewski
2014-10-02 22:26 ` Eduardo Valentin
2014-10-03 8:26 ` Lukasz Majewski
2014-10-06 18:01 ` Eduardo Valentin
2014-09-24 8:27 ` [PATCH 3/3] thermal: core: fix: Check return code of the ->get_max_state() callback Lukasz Majewski
2014-10-02 22:24 ` Eduardo Valentin
2014-10-03 10:40 ` Lukasz Majewski
2014-10-09 3:15 ` Zhang Rui
2014-10-09 16:47 ` Lukasz Majewski
2014-10-02 14:40 ` [PATCH 0/3] thermal: fix: Various fixes for thermal subsystem Lukasz Majewski
2014-11-13 17:02 ` [PATCH 0/8] thermal:cpu cooling:fix: Provide thermal core fixes with deferred probe for several drivers Lukasz Majewski
2014-11-13 17:02 ` [PATCH 1/8] thermal:cpu cooling:armada: Provide deferred probing for armada driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 2/8] thermal:cpu cooling:kirkwood: Provide deferred probing for kirkwood driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 3/8] thermal:cpu cooling:rcar: Provide deferred probing for rcar driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 4/8] thermal:cpu cooling:spear: Provide deferred probing for spear driver Lukasz Majewski
2014-11-13 17:02 ` [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver Lukasz Majewski
2014-11-14 10:47 ` Mikko Perttunen
2014-11-14 11:24 ` Lukasz Majewski
2014-11-17 11:57 ` Thierry Reding
2014-11-17 12:51 ` Lukasz Majewski
2014-11-17 13:18 ` Thierry Reding
2014-11-17 11:43 ` Thierry Reding
2014-11-17 11:50 ` Lukasz Majewski
2014-11-17 12:01 ` Thierry Reding
2014-11-17 13:02 ` Lukasz Majewski
2014-11-17 12:51 ` Mikko Perttunen [this message]
2014-11-17 13:08 ` Thierry Reding
2014-11-17 13:24 ` Mikko Perttunen
2014-11-17 11:40 ` Thierry Reding
2014-11-13 17:02 ` [PATCH 6/8] thermal:cpu cooling:ti: Provide deferred probing for ti drivers Lukasz Majewski
2014-11-20 19:00 ` Eduardo Valentin
2014-11-13 17:02 ` [PATCH 7/8] thermal:core:fix: Initialize the max_state variable to 0 Lukasz Majewski
2014-11-13 17:02 ` [PATCH 8/8] thermal:core:fix: Check return code of the ->get_max_state() callback Lukasz Majewski
2014-11-18 10:16 ` [PATCH v2] " Lukasz Majewski
2014-11-21 18:08 ` Eduardo Valentin
2014-11-24 10:38 ` Lukasz Majewski
2014-11-24 11:00 ` Viresh Kumar
2014-11-24 14:24 ` Lukasz Majewski
2014-11-25 10:46 ` Viresh Kumar
2014-11-24 18:02 ` Eduardo Valentin
2014-11-24 20:28 ` Lukasz Majewski
2014-11-20 18:54 ` [PATCH 0/8] thermal:cpu cooling:fix: Provide thermal core fixes with deferred probe for several drivers Eduardo Valentin
2014-11-21 8:33 ` Lukasz Majewski
2014-11-21 2:47 ` Eduardo Valentin
2014-11-21 16:28 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5469EF4C.1050007@kapsi.fi \
--to=mikko.perttunen@kapsi.fi \
--cc=b.zolnierkie@samsung.com \
--cc=edubezval@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gnurou@gmail.com \
--cc=iwamatsu@nigauri.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=l.majewski@majess.pl \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vincenzo.frascino@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome